Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Fix for 2363

Browse source 
There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read.  it should be something
like this:

Vol 28, No 7; Vol 28, No 8; Vol 28, No 9

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
Paul Poulain 2009-04-18 23:46:24 +02:00 committed by Galen Charlton
parent db2d97ae7f
commit ebfc2cdb1e
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
C4/Serials.pm
View file

@ -1106,9 +1106,9 @@ sub ModSubscriptionHistory {
WHERE subscriptionid=?
";
my $sth = $dbh->prepare($query);
$recievedlist =~ s/^,//g;
$missinglist =~ s/^,//g;
$opacnote =~ s/^,//g;
$recievedlist =~ s/^; //;
$missinglist =~ s/^; //;
$opacnote =~ s/^; //;
$sth->execute(
$histstartdate, $enddate, $recievedlist, $missinglist,
$opacnote, $librariannote, $subscriptionid
@ -1164,21 +1164,22 @@ sub ModSerialStatus {
my ( $missinglist, $recievedlist ) = $sth->fetchrow;
if ( $status eq 2 ) {
# warn "receivedlist : $recievedlist serialseq :$serialseq, ".index("$recievedlist","$serialseq");
$recievedlist .= ",$serialseq"
$recievedlist .= "; $serialseq"
unless ( index( "$recievedlist", "$serialseq" ) >= 0 );
}
# warn "missinglist : $missinglist serialseq :$serialseq, ".index("$missinglist","$serialseq");
$missinglist .= ",$serialseq"
$missinglist .= "; $serialseq"
if ( $status eq 4
and not index( "$missinglist", "$serialseq" ) >= 0 );
$missinglist .= ",not issued $serialseq"
$missinglist .= "; not issued $serialseq"
if ( $status eq 5
and index( "$missinglist", "$serialseq" ) >= 0 );
$query =
"UPDATE subscriptionhistory SET recievedlist=?, missinglist=? WHERE subscriptionid=?";
$sth = $dbh->prepare($query);
$recievedlist =~ s/^; //;
$missinglist =~ s/^; //;
$sth->execute( $recievedlist, $missinglist, $subscriptionid );
}
}
@ -1558,10 +1559,10 @@ sub NewIssue {
### TODO Add a feature that improves recognition and description.
### As such count (serialseq) i.e. : N18,2(N19),N20
### Would use substr and index But be careful to previous presence of ()
$recievedlist .= ",$serialseq" unless (index($recievedlist,$serialseq)>0);
$recievedlist .= "; $serialseq" unless (index($recievedlist,$serialseq)>0);
}
if ( $status eq 4 ) {
$missinglist .= ",$serialseq" unless (index($missinglist,$serialseq)>0);
$missinglist .= "; $serialseq" unless (index($missinglist,$serialseq)>0);
}
$query = qq|
UPDATE subscriptionhistory
@ -1569,6 +1570,8 @@ sub NewIssue {
WHERE subscriptionid=?
|;
$sth = $dbh->prepare($query);
$recievedlist =~ s/^; //;
$missinglist =~ s/^; //;
$sth->execute( $recievedlist, $missinglist, $subscriptionid );
return $serialid;
}