Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23081: set default to 0 for items.issues and deleteditems.issues

Browse source 
To test:
- save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items
- you should see a lot of nulls and no zeros
- apply patch
- updatedatabase
- re-run your query and see that your nulls have changed to zeros
- create a new item
- rerun your query and see your new item is counted in the zeros, not the nulls

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Andrew Fuerste-Henry 2020-04-26 23:51:25 +00:00 committed by Martin Renvoize
parent b50641b479
commit ec1bfd2b74
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
3 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Koha/Schema/Result/Deleteditem.pm
View file

@ -156,7 +156,8 @@ __PACKAGE__->table("deleteditems");
=head2 issues
data_type: 'smallint'
is_nullable: 1
is_nullable: 0
default_value: 0
=head2 renewals
@ -341,7 +342,10 @@ __PACKAGE__->add_columns(
"coded_location_qualifier",
{ data_type => "varchar", is_nullable => 1, size => 10 },
"issues",
{ data_type => "smallint", is_nullable => 1 },
{ data_type => "smallint",
is_nullable => 0,
default_value => 0,
},
"renewals",
{ data_type => "smallint", is_nullable => 1 },
"reserves",

8
Koha/Schema/Result/Item.pm
View file

@ -159,7 +159,8 @@ __PACKAGE__->table("items");
=head2 issues
data_type: 'smallint'
is_nullable: 1
is_nullable: 0
default_value: 0
=head2 renewals
@ -355,7 +356,10 @@ __PACKAGE__->add_columns(
"coded_location_qualifier",
{ data_type => "varchar", is_nullable => 1, size => 10 },
"issues",
{ data_type => "smallint", is_nullable => 1 },
{ data_type => "smallint",
is_nullable => 0,
default_value => 0,
},
"renewals",
{ data_type => "smallint", is_nullable => 1 },
"reserves",

4
installer/data/mysql/kohastructure.sql
View file

@ -638,7 +638,7 @@ CREATE TABLE `deleteditems` (
`withdrawn_on` datetime DEFAULT NULL, -- the date and time an item was last marked as withdrawn, NULL if not withdrawn
`itemcallnumber` varchar(255) default NULL, -- call number for this item (MARC21 952$o)
`coded_location_qualifier` varchar(10) default NULL, -- coded location qualifier(MARC21 952$f)
`issues` smallint(6) default NULL, -- number of times this item has been checked out
`issues` smallint(6) default 0, -- number of times this item has been checked out
`renewals` smallint(6) default NULL, -- number of times this item has been renewed
`reserves` smallint(6) default NULL, -- number of times this item has been placed on hold/reserved
`restricted` tinyint(1) default NULL, -- authorized value defining use restrictions for this item (MARC21 952$5)
@ -843,7 +843,7 @@ CREATE TABLE `items` ( -- holdings/item information
`withdrawn_on` datetime DEFAULT NULL, -- the date and time an item was last marked as withdrawn, NULL if not withdrawn
`itemcallnumber` varchar(255) default NULL, -- call number for this item (MARC21 952$o)
`coded_location_qualifier` varchar(10) default NULL, -- coded location qualifier(MARC21 952$f)
`issues` smallint(6) default NULL, -- number of times this item has been checked out/issued
`issues` smallint(6) default 0, -- number of times this item has been checked out/issued
`renewals` smallint(6) default NULL, -- number of times this item has been renewed
`reserves` smallint(6) default NULL, -- number of times this item has been placed on hold/reserved
`restricted` tinyint(1) default NULL, -- authorized value defining use restrictions for this item (MARC21 952$5)