Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*)

Browse source 
Text editors can create temporary files in this folder and this can
confuse the translator.
For instance, vim can create a file named '.opac.pref.swp' which will
make the translator dies with the following error message:

Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use
at LangInstaller.pm line 248.

Test plan:
1. echo 'Oops' > .../en/modules/admin/preferences/whatever.pref.whatever
2. cd misc/translator && ./translate update fr-FR
3. Verify that you have the error message mentioned above
4. Apply patch
5. cd misc/translator && ./translate update fr-FR
6. No more errors!

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Julian Maurice 2017-07-06 14:39:20 +02:00 committed by Jonathan Druart
parent 441f6fac33
commit ec51335e9c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
misc/translator/LangInstaller.pm
View file

@ -82,7 +82,7 @@ sub new {
# Get all .pref file names
opendir my $fh, $self->{path_pref_en};
my @pref_files = grep { /.pref/ } readdir($fh);
my @pref_files = grep { /.pref$/ } readdir($fh);
close $fh;
$self->{pref_files} = \@pref_files;