Bug 34572: Simplify template logic around check-in input form

This patch makes a minor simplifying change to the check-in template
around how to style the barcode input field in dropbox or fine-exempt
mode.

To test, apply the patch and go to Circulation.

- If necessary, check some items out to patrons so that you have items
  to check in.
- Go to the check-in page and click the icon inside the barcode field to
  expand the panel of options.
- Check the "book drop mode" checkbox. The barcode field should now be
  highlighted yellow.
- Check in an item. When the page redisplays, the barcode field should
  have the same highlighted style.

- If necessary, enable the finesMode system preference.
- On the check-in page, in the panel of options, check the "Forgive
  overdue fines" checkbox. Test checking in again, confirming the same
  style consistency in the barcode field.

Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-08-18 07:40:16 +00:00 committed by Tomas Cohen Arazi
parent 00edf9a541
commit edb9787fc8
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F

View file

@ -1089,12 +1089,10 @@
<div class="row">
<div class="col-sm-6">
<div class="form-control-group">
[% IF ( exemptfine ) %]
[% IF ( exemptfine || dropboxmode ) %]
<input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" />
[% ELSIF ( dropboxmode ) %]
<input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" />
[% ELSE %]
<input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus" />
<input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus" type="text" />
[% END %]
<div id="show-circ-settings">