Bug 11464: Prevent wrong "nothing to save" message on saving syspref
Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
parent
e5858e16ec
commit
ee478c3605
1 changed files with 1 additions and 1 deletions
|
@ -63,7 +63,7 @@ $( document ).ready( function () {
|
|||
}
|
||||
|
||||
$( '.prefs-tab' )
|
||||
.find( 'input.preference, textarea.preference' ).keyup( function () {
|
||||
.find( 'input.preference, textarea.preference' ).on('change', function () {
|
||||
if ( this.defaultValue === undefined || this.value != this.defaultValue ) mark_modified.call( this );
|
||||
} ).end()
|
||||
.find( 'select.preference' ).change( mark_modified );
|
||||
|
|
Loading…
Reference in a new issue