Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm

Browse source 
Bareword file handle opened at line 80, column 9.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 80, column 9.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

http://perldoc.perl.org/functions/open.html
For three or more arguments if MODE is |- , the filename is interpreted
as a command to which output is to be piped, and if MODE is -| , the
filename is interpreted as a command that pipes output to us. I

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Mason James 2012-06-27 05:02:00 +12:00 committed by Paul Poulain
parent 2b817cc120
commit ef22d9e266
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
C4/Print.pm
View file

@ -67,9 +67,11 @@ sub NetworkPrint {
# set the queue to "file" (or " file", if real queues aren't allowed
# to have spaces in them). Or perhaps if $queue eq "" and
# $env->{file} ne "", then that should mean "print to $env->{file}".
my $fh;
if ( $queue eq "" || $queue eq 'nulllp' ) {
return;
#open( PRINTER, ">/tmp/kohaiss" );
#open( $fh, ">/tmp/kohaiss" );
}
else {
@ -77,15 +79,15 @@ sub NetworkPrint {
# This is a reasonable assumption, but only because every other
# printing package has a wrapper script called 'lpr'. It'd still
# be better to be able to customize this.
open( PRINTER, "| lpr -P $queue > /dev/null" )
open( $fh, "-|", "lpr -P $queue > /dev/null" )
or die "Couldn't write to queue:$queue!\n";
}
# print $queue;
#open (FILE,">/tmp/$file");
print PRINTER $text;
print PRINTER "\r\n" x 7 ;
close PRINTER;
print $fh $text;
print $fh "\r\n" x 7 ;
close $fh;
#system("lpr /tmp/$file");
}