Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page

Browse source 
This patch removes the use of the jquery.checkboxes plugin from the
suggestions management page and replaces it with custom JS.

To test, apply the patch and go to Acquisitions -> Suggestions

Under each tab ("Accepted," "Pending," etc.), test that the "Check all"
and "Uncheck all" controls work correctly and only affect the table on
that tab.

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Owen Leonard 2020-08-05 17:27:58 +00:00 committed by Jonathan Druart
parent 8620d1ec4b
commit f0275e6677
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View file

@ -1024,8 +1024,6 @@
[% IF op == 'else' %]
[% INCLUDE 'datatables.inc' %]
[% INCLUDE 'columns_settings.inc' %]
[% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
<script>
$(document).ready(function() {
$('#suggestiontabs').tabs();
@ -1050,13 +1048,15 @@
$(".checkall").click(function(e){
e.preventDefault();
$(this).parents('form').checkCheckboxes();
return false;
$(this).parents('form').find("input:checkbox").each(function(){
$(this).prop("checked", true);
});
});
$(".uncheckall").click(function(e){
e.preventDefault();
$(this).parents('form').unCheckCheckboxes();
return false;
$(this).parents('form').find("input:checkbox").each(function(){
$(this).prop("checked", false);
});
});
$(".other_reason").hide();
$("select[name='reason']").change(function(){