Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35042: Remove set datelastseen to null on table in Members.t

Browse source 
Non-trivial was adding the category_type <> S.

Test plan:
Run t/db_dependent/Members.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-10-12 09:56:25 +00:00 committed by Tomas Cohen Arazi
parent 4b337b107e
commit f08fc01867
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
t/db_dependent/Members.t
View file

@ -281,12 +281,17 @@ $patstodel = GetBorrowersToExpunge( {not_borrowed_since => '2016-01-02', patron_
is( scalar(@$patstodel),2,'Borrowers without issues deleted by last issue date');
# Test GetBorrowersToExpunge and TrackLastPatronActivity
$dbh->do(q|UPDATE borrowers SET lastseen=NULL|);
my $new_category = $builder->build_object(
{
class => 'Koha::Patron::Categories',
value => { category_type => 'A' }, # should not be S for GetBorrowersToExpunge
}
);
$builder->build({
source => 'Borrower',
value => {
lastseen => '2016-01-01 01:01:01',
categorycode => 'CIVILIAN',
categorycode => $new_category->categorycode,
flags => undef,
}
});
@ -294,7 +299,7 @@ $builder->build({
source => 'Borrower',
value => {
lastseen => '2016-02-02 02:02:02',
categorycode => 'CIVILIAN',
categorycode => $new_category->categorycode,
flags => undef,
}
});
@ -302,15 +307,15 @@ $builder->build({
source => 'Borrower',
value => {
lastseen => '2016-03-03 03:03:03',
categorycode => 'CIVILIAN',
categorycode => $new_category->categorycode,
flags => undef,
}
});
$patstodel = GetBorrowersToExpunge( { last_seen => '1999-12-12' });
$patstodel = GetBorrowersToExpunge( { category_code => $new_category->categorycode, last_seen => '1999-12-12' });
is( scalar @$patstodel, 0, 'TrackLastPatronActivity - 0 patrons must be deleted' );
$patstodel = GetBorrowersToExpunge( { last_seen => '2016-02-15' });
$patstodel = GetBorrowersToExpunge( { category_code => $new_category->categorycode, last_seen => '2016-02-15' });
is( scalar @$patstodel, 2, 'TrackLastPatronActivity - 2 patrons must be deleted' );
$patstodel = GetBorrowersToExpunge( { last_seen => '2016-04-04' });
$patstodel = GetBorrowersToExpunge( { category_code => $new_category->categorycode, last_seen => '2016-04-04' });
is( scalar @$patstodel, 3, 'TrackLastPatronActivity - 3 patrons must be deleted' );
my $patron2 = $builder->build({
source => 'Borrower',