Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 7450: missing placeholders in authorised_values.pl

Browse source 
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Successfully added, edited and deleted authorised values.
No problems found.
This commit is contained in:
Adrien Saurat 2012-01-17 12:00:32 +01:00 committed by Paul Poulain
parent cf15a0e427
commit f0a6600934
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
admin/authorised_values.pl
View file

@ -104,13 +104,13 @@ if ($op eq 'add_form') {
my $duplicate_entry = 0;
if ( $id ) { # Update
my $sth = $dbh->prepare( "SELECT category, authorised_value FROM authorised_values WHERE id='$id' ");
$sth->execute();
my $sth = $dbh->prepare( "SELECT category, authorised_value FROM authorised_values WHERE id = ? ");
$sth->execute($id);
my ($category, $authorised_value) = $sth->fetchrow_array();
if ( $authorised_value ne $new_authorised_value ) {
my $sth = $dbh->prepare_cached( "SELECT COUNT(*) FROM authorised_values " .
"WHERE category = '$new_category' AND authorised_value = '$new_authorised_value' and id<>$id");
$sth->execute();
"WHERE category = ? AND authorised_value = ? and id <> ? ");
$sth->execute($new_category, $new_authorised_value, $id);
($duplicate_entry) = $sth->fetchrow_array();
warn "**** duplicate_entry = $duplicate_entry";
}
@ -133,8 +133,8 @@ if ($op eq 'add_form') {
}
else { # Insert
my $sth = $dbh->prepare_cached( "SELECT COUNT(*) FROM authorised_values " .
"WHERE category = '$new_category' AND authorised_value = '$new_authorised_value' ");
$sth->execute();
"WHERE category = ? AND authorised_value = ? ");
$sth->execute($new_category, $new_authorised_value);
($duplicate_entry) = $sth->fetchrow_array();
unless ( $duplicate_entry ) {
my $sth=$dbh->prepare( 'INSERT INTO authorised_values