Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22049: Do not pass Koha::Patron to AddIssue

Browse source 
The tests are not supposed to pass with such obvious mistake (?)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2019-02-21 18:03:21 -03:00 committed by Nick Clemens
parent 986d551ac4
commit f0aa1c06a1
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
t/db_dependent/Circulation/MarkIssueReturned.t
View file

@ -69,7 +69,7 @@ subtest 'Failure tests' => sub {
is( $issue_id, undef, 'No issue_id returned' );
# In the next call we return the item and try it another time
$issue = C4::Circulation::AddIssue( $patron, $item->barcode );
$issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
eval { $issue_id = C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0 ) };
is( $issue_id, $issue->issue_id, "Item has been returned (issue $issue_id)" );
eval { $issue_id = C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0 ) };
@ -172,7 +172,7 @@ subtest 'Manually pass a return date' => sub {
my $old_checkout = Koha::Old::Checkouts->find( $issue_id );
is( $old_checkout->returndate, '2018-12-25 00:00:00', 'Manually passed date stored correctly' );
$issue = C4::Circulation::AddIssue( $patron, $item->barcode );
$issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
throws_ok
{ $issue_id = C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, 'bad_date', 0 ); }