Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11416: fix case where serials item editor was incorrectly hiding fields

Browse source 
In serials/serials-edit.pl, if an item field is hidden from the OPAC,
it will not display in the editor, even if the field is marked as
visible in the staff intranet and editor. However, the field is still
displayed correctly in the items editor ( additem.pl ).:

Test Plan:
1) Select an item-level field ( e.g. non-public note )
2) Create a serial using the default framework ( or one of your choice )
3) For that framework, mark the chosen field as visible from the
intranet and editor, but not the opac.
4) Receive an item for this serial, note your field does not display
5) Use the biblio item editor to add an item ( additem.pl ), not the
field displayes
6) Apply this patch
7) Repeat step 4, not the field displayes

Signed-off-by: Kim Schwant <kim.schwant@courts.in.gov>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
PrepareItemrecordDisplay is only used for editor (-4 < hidden < 4)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Kyle Hall 2013-12-18 08:37:40 -05:00 committed by Galen Charlton
parent 7f1e949ea0
commit f140207808
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
C4/Items.pm
View file

@ -2688,7 +2688,8 @@ sub PrepareItemrecordDisplay {
$subfield_data{mandatory} = $tagslib->{$tag}->{$subfield}->{mandatory};
$subfield_data{repeatable} = $tagslib->{$tag}->{$subfield}->{repeatable};
$subfield_data{hidden} = "display:none"
if $tagslib->{$tag}->{$subfield}->{hidden};
if ( ( $tagslib->{$tag}->{$subfield}->{hidden} > 4 )
|| ( $tagslib->{$tag}->{$subfield}->{hidden} < -4 ) );
my ( $x, $defaultvalue );
if ($itemrecord) {
( $x, $defaultvalue ) = _find_value( $tag, $subfield, $itemrecord );