Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28854: (QA follow-up) Remove duplicate key test

Browse source 
We now allow duplication of issue_id accross the return claims table (to
allow for the case where a bundle item has been loaned and thus multiple
claims can result from the same checkout.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2022-07-11 16:08:05 +01:00 committed by Tomas Cohen Arazi
parent 6436629d86
commit f22a40b8ba
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
t/db_dependent/Koha/Checkouts/ReturnClaim.t
View file

@ -31,7 +31,7 @@ my $builder = t::lib::TestBuilder->new;
subtest "store() tests" => sub {
plan tests => 13;
plan tests => 11;
$schema->storage->txn_begin;
@ -109,31 +109,6 @@ subtest "store() tests" => sub {
is( ref($claim), 'Koha::Checkouts::ReturnClaim', 'Object type is correct' );
is( Koha::Checkouts::ReturnClaims->search( { issue_id => $checkout->id } )->count, 1, 'Claim stored on the DB');
{ # hide useless warnings
local *STDERR;
open STDERR, '>', '/dev/null';
throws_ok {
Koha::Checkouts::ReturnClaim->new(
{
issue_id => $checkout->id,
itemnumber => $checkout->itemnumber,
borrowernumber => $checkout->borrowernumber,
notes => 'Some notes',
created_by => $librarian->borrowernumber
}
)->store;
}
'Koha::Exceptions::Object::DuplicateID',
'An exception is thrown on duplicate issue_id';
close STDERR;
like(
$@->duplicate_id,
qr/(return_claims\.)?issue_id/,
'Exception field is correct'
);
}
{ # hide useless warnings
local *STDERR;
open STDERR, '>', '/dev/null';