Bug 33000: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

This follow-up includes a change to admin/cities.tt as well.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 95891fe1e8)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2023-02-23 22:29:16 +00:00 committed by Matt Blenkinsop
parent f1ae055b18
commit f2e6e90d9c
12 changed files with 18 additions and 17 deletions

View file

@ -18,7 +18,7 @@
[% WRAPPER 'sub-header.inc' %]
[% WRAPPER breadcrumbs %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Acquisitions
<span>Acquisitions</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END %]

View file

@ -43,7 +43,7 @@
<a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketno | html %]</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Add orders from MARC file
<span>Add orders from MARC file</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -51,11 +51,11 @@
<span>New</span>
[% END %]
[% END %]
<span>Basket [% basketname | html %]
[% IF ( basketno ) %]
([% basketno | html %])
<span>Basket [% basketname | html %] ([% basketno | html %]) for [% booksellername | html %]</span>
[% ELSE %]
<span>Basket [% basketname | html %] for [% booksellername | html %]</span>
[% END %]
for [% booksellername | html %]</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -111,14 +111,14 @@
<a href="/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=[% booksellerid | uri %]">Basket grouping</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Add basket group for [% booksellername | html %]
<span>Add basket group for [% booksellername | html %]</span>
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% booksellername | html %]</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Basket grouping
<span>Basket grouping</span>
[% END %]
[% END # /IF grouping %]
[% END #/ WRAPPER breadcrumbs %]

View file

@ -30,11 +30,11 @@
[% IF ( add_form ) %]
[% IF ( basketno ) %]
[% WRAPPER breadcrumb_item bc_active= 1%]
Edit basket '[% basketname | html %]'
<span>Edit basket '[% basketname | html %]'</span>
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1%]
Add a basket to [% booksellername | html %]
<span>Add a basket to [% booksellername | html %]</span>
[% END %]
[% END %]
[% END %]

View file

@ -4,6 +4,7 @@
[% USE Asset %]
[% USE AuthorisedValues %]
[% USE KohaDates %]
[% USE HtmlTags %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Search for vendor [% supplier | html %] &rsaquo; Koha</title>
@ -26,7 +27,7 @@
<a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Search for vendor <em>[% supplier | html %]</em>
<span>Search for vendor [% supplier | $HtmlTags tag='em' %]</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -19,7 +19,7 @@
<a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | uri %]">Basket [% basket.basketname | html %] ([% basket.basketno | html %]) for [% basket.bookseller.name | html %]</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Cancel order
<span>Cancel order</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -35,7 +35,7 @@ Acquisitions &rsaquo; Koha
<a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | uri %]">Basket [% basket.basketno | html %]</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Duplicate existing orders
<span>Duplicate existing orders</span>
[% END %]
[% END # /UNLESS blocking_error %]
[% END #/ WRAPPER breadcrumbs %]

View file

@ -15,7 +15,7 @@
<a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Basket ([% basketno | html %])
<span>Basket ([% basketno | html %])</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -21,7 +21,7 @@
<a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
EDIFACT messages
<span>EDIFACT messages</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -14,7 +14,7 @@
<a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
EDIFACT messages
<span>EDIFACT messages</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]

View file

@ -46,12 +46,12 @@
<a href="/cgi-bin/koha/admin/cities.pl">Cities</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active = 1 %]
Confirm deletion of city
<span>Confirm deletion of city</span>
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active = 1 %]
Cities
<span>Cities</span>
[% END %]
[% END #/IF op = add_form %]