Bug 15839: Koha::Reviews - Remove deletereview

Note that a future enhancement should take into account the possible
error returned by ->approve, ->unapprove and ->delete

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-02-16 16:06:46 +00:00 committed by Kyle M Hall
parent 7a10e15dae
commit f3b57dfb02
2 changed files with 3 additions and 20 deletions

View file

@ -27,8 +27,7 @@ use vars qw(@ISA @EXPORT);
BEGIN {
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(getreview savereview updatereview numberofreviews numberofreviewsbybiblionumber
deletereview);
@EXPORT = qw(getreview savereview updatereview numberofreviews numberofreviewsbybiblionumber);
}
=head1 NAME
@ -138,23 +137,6 @@ sub numberofreviewsbybiblionumber {
return $sth->fetchrow;
}
=head2 deletereview
deletereview($reviewid);
Takes a reviewid and deletes it
=cut
sub deletereview {
my ($reviewid) = @_;
my $dbh = C4::Context->dbh();
my $query = "DELETE FROM reviews
WHERE reviewid=?";
my $sth = $dbh->prepare($query);
$sth->execute($reviewid);
}
1;
__END__

View file

@ -54,7 +54,8 @@ elsif ( $op eq 'unapprove' ) {
$review->unapprove if $review;
}
elsif ( $op eq 'delete' ) {
deletereview($reviewid);
my $review = Koha::Reviews->find( $reviewid );
$review->delete if $review;
}
my $reviews = Koha::Reviews->search(