Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20031: CGI param in list context warn in guided_reports.pl

Browse source 
Resolve warn:
CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_shadowclone_reports_guided_reports_2epl line 794, this can lead to vulnerabilities. [NOTE: line number from older Koha version.]

Test plan:
Looking at this change should convince you already. Another look at this
routine in C4/Output.pm would be bonus.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2018-01-18 15:40:15 +01:00 committed by Jonathan Druart
parent b65f1f4c94
commit f3c6284835
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reports/guided_reports.pl
View file

@ -813,7 +813,7 @@ elsif ($phase eq 'Run this report'){
'name' => $name,
'notes' => $notes,
'errors' => defined($errors) ? [ $errors ] : undef,
'pagination_bar' => pagination_bar($url, $totpages, $input->param('page')),
'pagination_bar' => pagination_bar($url, $totpages, scalar $input->param('page')),
'unlimited_total' => $total,
'sql_params' => \@sql_params,
);