Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15451: Koha::CsvProfiles - Remove the residue

Browse source 
This patch erase all traces of C4::Csv since it's not used anymore.
All occurrences have been replaced by previous patches to use
Koha::CsvProfiles.

Note that GetMarcFieldsForCsv was not used prior this patch set.

Test plan:
  git grep 'C4::Csv'
should not return any result.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more traces of the file.
This produces a koha-qa fail, due to the missing file.
No other errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2015-12-30 18:28:55 +00:00 committed by Kyle M Hall
parent 0e80c75aee
commit f3d7f27107
12 changed files with 1 additions and 131 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
C4/Csv.pm
View file

@ -1,54 +0,0 @@
package C4::Csv;
# Copyright 2008 BibLibre
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
#
#
#use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
use vars qw(@ISA @EXPORT);
@ISA = qw(Exporter);
# only export API methods
@EXPORT = qw(
&GetMarcFieldsForCsv
);
# Returns fields to extract for the given csv profile
sub GetMarcFieldsForCsv {
my ($id) = @_;
my $dbh = C4::Context->dbh;
my $query = "SELECT content FROM export_format WHERE export_format_id=?";
$sth = $dbh->prepare($query);
$sth->execute($id);
return ($sth->fetchrow_hashref)->{content};
}
1;

1
C4/Record.pm
View file

@ -29,7 +29,6 @@ use MARC::File::XML; # marc2marcxml, marcxml2marc, changeEncoding
use Biblio::EndnoteStyle;
use Unicode::Normalize; # _entity_encode
use C4::Biblio; #marc2bibtex
use C4::Csv; #marc2csv
use C4::Koha; #marc2csv
use C4::XSLT ();
use YAML; #marcrecords2csv

1
basket/downloadcart.pl
View file

@ -28,7 +28,6 @@ use C4::Items;
use C4::Output;
use C4::Record;
use C4::Ris;
use C4::Csv;
use Koha::CsvProfiles;

1
misc/export_records.pl
View file

@ -24,7 +24,6 @@ use Pod::Usage;
use C4::Auth;
use C4::Context;
use C4::Csv;
use C4::Record;
use Koha::Biblioitems;

1
opac/opac-downloadcart.pl
View file

@ -28,7 +28,6 @@ use C4::Items;
use C4::Output;
use C4::Record;
use C4::Ris;
use C4::Csv;
use Koha::CsvProfiles;

1
opac/opac-downloadshelf.pl
View file

@ -28,7 +28,6 @@ use C4::Items;
use C4::Output;
use C4::Record;
use C4::Ris;
use C4::Csv;
use Koha::CsvProfiles;
use Koha::Virtualshelves;

2
serials/claims.pl
View file

@ -27,9 +27,9 @@ use C4::Context;
use C4::Letters;
use C4::Branch; # GetBranches GetBranchesLoop
use C4::Koha qw( GetAuthorisedValues );
use Koha::AdditionalField;
use Koha::CsvProfiles;
use C4::Csv;
my $input = CGI->new;

1
serials/lateissues-export.pl
View file

@ -22,7 +22,6 @@ use C4::Serials;
use C4::Acquisition;
use C4::Output;
use C4::Context;
use C4::Csv;
use Koha::CsvProfiles;

67
t/db_dependent/Csv.t
View file

@ -1,67 +0,0 @@
#!/usr/bin/perl
use strict;
use warnings;
use Test::More tests => 10;
use Test::Deep;
use C4::Context;
BEGIN {
use_ok('C4::Csv');
}
my $dbh = C4::Context->dbh;
$dbh->{AutoCommit} = 0;
$dbh->{RaiseError} = 1;
$dbh->do('DELETE FROM export_format');
my $sth = $dbh->prepare(q{
INSERT INTO export_format (profile, description, content, type)
VALUES (?, ?, ?, ?)
});
$sth->execute('MARC', 'MARC profile', '245$a', 'marc');
$sth->execute('SQL', 'SQL profile', 'borrowers.surname', 'sql');
my $all_profiles = C4::Csv::GetCsvProfiles();
is(@$all_profiles, 2, 'test getting all CSV profiles');
my $sql_profiles = C4::Csv::GetCsvProfiles('sql');
is(@$sql_profiles, 1, 'test getting SQL CSV profiles');
is($sql_profiles->[0]->{profile}, 'SQL', '... and got the right one');
my $marc_profiles = C4::Csv::GetCsvProfiles('marc');
is(@$marc_profiles, 1, 'test getting MARC CSV profiles');
is($marc_profiles->[0]->{profile}, 'MARC', '... and got the right one');
my $id = C4::Csv::GetCsvProfileId('MARC');
my $profile = C4::Csv::GetCsvProfile($id);
is($profile->{profile}, 'MARC', 'retrieved profile by ID');
is(C4::Csv::GetCsvProfile(), undef, 'test getting CSV profile but not supplying ID');
cmp_deeply(
C4::Csv::GetCsvProfilesLoop(),
[
{
export_format_id => ignore(),
profile => 'MARC',
},
{
export_format_id => ignore(),
profile => 'SQL',
},
],
'test getting profile loop'
);
cmp_deeply(
C4::Csv::GetCsvProfilesLoop('marc'),
[
{
export_format_id => ignore(),
profile => 'MARC',
},
],
'test getting profile loop for one type'
);

1
tools/export.pl
View file

@ -22,7 +22,6 @@ use MARC::File::XML;
use List::MoreUtils qw(uniq);
use C4::Auth;
use C4::Branch; # GetBranches
use C4::Csv;
use C4::Koha; # GetItemTypes
use C4::Output;

1
virtualshelves/downloadshelf.pl
View file

@ -28,7 +28,6 @@ use C4::Items;
use C4::Output;
use C4::Record;
use C4::Ris;
use C4::Csv;
use Koha::CsvProfiles;
use Koha::Virtualshelves;

1
virtualshelves/shelves.pl
View file

@ -21,7 +21,6 @@ use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth;
use C4::Biblio;
use C4::Csv;
use C4::Koha;
use C4::Items;
use C4::Members;