Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33573: Unit tests

Browse source 
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 24d753cda1)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomás Cohen Arazi 2023-06-07 10:41:53 -03:00 committed by Martin Renvoize
parent e495547b8b
commit f430c075c1
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 79 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
t/db_dependent/api/v1/patrons_holds.t
View file

@ -17,7 +17,8 @@
use Modern::Perl;
use Test::More tests => 1;
use Test::More tests => 2;
use Test::MockModule;
use Test::Mojo;
use t::lib::TestBuilder;
@ -68,3 +69,80 @@ subtest 'list() tests' => sub {
$schema->storage->txn_rollback;
};
subtest 'delete_public() tests' => sub {
plan tests => 13;
$schema->storage->txn_begin;
t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
my $patron = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0 },
}
);
my $password = 'thePassword123';
$patron->set_password( { password => $password, skip_validation => 1 } );
my $userid = $patron->userid;
my $hold_to_delete = $builder->build_object( { class => 'Koha::Holds' } );
my $deleted_hold_id = $hold_to_delete->id;
$hold_to_delete->delete;
$t->delete_ok( "//$userid:$password@/api/v1/public/patrons/" . $patron->id . '/holds/' . $deleted_hold_id )
->status_is(404);
my $another_user_hold = $builder->build_object( { class => 'Koha::Holds' } );
$t->delete_ok( "//$userid:$password@/api/v1/public/patrons/" . $patron->id . '/holds/' . $another_user_hold->id )
->status_is( 404, 'Invalid patron_id and hold_id combination yields 404' );
my $non_waiting_hold = $builder->build_object(
{
class => 'Koha::Holds',
value => {
borrowernumber => $patron->id,
found => undef,
itemnumber => undef
}
}
);
$t->delete_ok( "//$userid:$password@/api/v1/public/patrons/" . $patron->id . '/holds/' . $non_waiting_hold->id )
->status_is( 204, 'SWAGGER3.2.4' )->content_is( '', 'SWAGGER3.3.4' );
my $cancellation_requestable;
my $hold_mock = Test::MockModule->new('Koha::Hold');
$hold_mock->mock( 'cancellation_requestable_from_opac', sub { return $cancellation_requestable; } );
my $item = $builder->build_sample_item;
my $waiting_hold = $builder->build_object(
{
class => 'Koha::Holds',
value => {
borrowernumber => $patron->id,
found => 'W',
itemnumber => $item->id,
}
}
);
$cancellation_requestable = 0;
$t->delete_ok( "//$userid:$password@/api/v1/public/patrons/" . $patron->id . '/holds/' . $waiting_hold->id )
->status_is(403)->json_is( { error => 'Cancellation forbidden' } );
$cancellation_requestable = 1;
$t->delete_ok( "//$userid:$password@/api/v1/public/patrons/" . $patron->id . '/holds/' . $waiting_hold->id )
->status_is(202);
my $cancellation_requests = $waiting_hold->cancellation_requests;
is( $cancellation_requests->count, 1, 'Cancellation request recorded' );
$schema->storage->txn_rollback;
};