Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35857: Update authority search pop-up windows with consistent footer markup

Browse source 
This patch updates the cataloging authority finder template in order to
style submission and close buttons in a fixed footer at the bottom of
the pop-up window, with markup consistent with other pop-up windows.

Some inline CSS has been removed in favor of styling the "Clear" button
like a default button. Unrelated, "No results found" message has been
wrapped in a "dialog message" div for consistency's sake.

To test, apply the patch and go to Cataloging -> New record.

- In the "Add MARC record" form, locate a tag which is linked to an
  authority type, e.g. 100$a.
- Click the icon to the right of the field to trigger the authority
  search window.
- There should be a fixed footer in the pop-up window with buttons for
  "Submit," "Clear form," and "Close window." Test that each behave
  correctly.
  - The search results view should have the same footer.
  - Clicking "Choose" from the search results should close the window
    and populate the MARC tag with the correct authority data.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Owen Leonard 2024-01-26 18:35:50 +00:00 committed by Katrin Fischer
parent 34cc0d29df
commit f49f76d60a
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
3 changed files with 15 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
View file

@ -179,6 +179,14 @@
</ol>
</fieldset>
[% END %]
<fieldset class="action"> <input type="submit" value="Search" class="submit" id="search" /> <input type="reset" id="clear-form" value="Clear form"> <a id="cancel" class="cancel close" href="#">Cancel</a>
</fieldset>
<nav class="navbar navbar-default navbar-fixed-bottom">
<div class="container-fluid">
<fieldset class="action">
<input type="submit" class="btn btn-primary" id="search" value="Search" />
<input type="reset" id="clear-form" class="btn btn-default" value="Clear form" />
<button type="button" class="btn btn-default close_window">Close window</button>
</fieldset>
</div>
</nav>
</form>

11
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt
View file

@ -8,17 +8,6 @@
[% t("Koha") | html %]
[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
<style>
#clear-form {
border:0;
background:none;
color:#004d99;
padding-left:1em;
}
#clear-form:hover {
color:#538200;
}
</style>
</head>
<body id="auth_auth_finder" class="auth">

15
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
View file

@ -19,15 +19,6 @@
.usefor li {
list-style-type: none;
}
#clear-form {
border:0;
background:none;
color:#004d99;
padding-left:1em;
}
#clear-form:hover {
color:#538200;
}
</style>
</head>
@ -60,7 +51,11 @@
[% ELSE %]
</div><p>No results found</p>[% END %]
</div>
<div class="dialog message">
<p>No results found</p>
</div>
[% END %]
</div>
[% IF ( result ) %]<div id="resultlist">
<table>