Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36367: Remove dbh_stack

Browse source 
Same pattern, remove dbh stack

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2024-03-11 15:12:09 +01:00 committed by Martin Renvoize
parent 40280d79f9
commit f4ed78de2c
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 0 additions and 61 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
C4/Context.pm
View file

@ -97,9 +97,6 @@ environment variable to the pathname of a configuration file to use.
# file (/etc/koha/koha-conf.xml).
# dbh
# A handle to the appropriate database for this context.
# dbh_stack
# Used by &set_dbh and &restore_dbh to hold other database
# handles for this context.
# Zconn
# A connection object for the Zebra server
@ -602,14 +599,8 @@ Returns a database handle connected to the Koha database for the
current context. If no connection has yet been made, this method
creates one, and connects to the database.
This database handle is cached for future use: if you call
C<C4::Context-E<gt>dbh> twice, you will get the same handle both
times. If you need a second database handle, use C<&new_dbh> and
possibly C<&set_dbh>.
=cut
#'
sub dbh
{
my $self = shift;
@ -643,58 +634,6 @@ sub new_dbh
return &dbh({ new => 1 });
}
=head2 set_dbh
$my_dbh = C4::Connect->new_dbh;
C4::Connect->set_dbh($my_dbh);
...
C4::Connect->restore_dbh;
C<&set_dbh> saves the current database handle on a stack, then sets
the current database handle to C<$my_dbh>.
C<$my_dbh> is assumed to be a good database handle.
=cut
#'
sub set_dbh
{
my $self = shift;
my $new_dbh = shift;
# Save the current database handle on the handle stack.
# We assume that $new_dbh is all good: if the caller wants to
# screw himself by passing an invalid handle, that's fine by
# us.
push @{$context->{"dbh_stack"}}, $context->{"dbh"};
$context->{"dbh"} = $new_dbh;
}
=head2 restore_dbh
C4::Context->restore_dbh;
Restores the database handle saved by an earlier call to
C<C4::Context-E<gt>set_dbh>.
=cut
#'
sub restore_dbh
{
my $self = shift;
if ($#{$context->{"dbh_stack"}} < 0)
{
# Stack underflow
die "DBH stack underflow";
}
# Pop the old database handle and set it.
$context->{"dbh"} = pop @{$context->{"dbh_stack"}};
}
=head2 userenv
C4::Context->userenv;