Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25946: (QA follow-up) Add Unit tests

Browse source 
Add a unit test for the empty relationship availability.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2021-03-30 15:47:12 +01:00 committed by Jonathan Druart
parent 8245bc6f2d
commit f744dfe60c
1 changed files with 30 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
t/db_dependent/Koha/Patron/Relationship.t
View file

@ -35,7 +35,7 @@ my $builder = t::lib::TestBuilder->new;
subtest 'store() tests' => sub {
plan tests => 9;
plan tests => 13;
$schema->storage->txn_begin;
@ -76,7 +76,23 @@ subtest 'store() tests' => sub {
'No guarantors added'
);
$relationship_1->relationship('father1')->store;
$relationship = '';
throws_ok
{ $relationship_1->relationship($relationship)->store; }
'Koha::Exceptions::Patron::Relationship::InvalidRelationship',
'Exception is thrown as a wrong relationship was passed';
is( "$@", "Invalid relationship passed, '$relationship' is not defined.", 'Exception stringified correctly' );
is( Koha::Patron::Relationships->search( { guarantee_id => $patron_1->borrowernumber } )->count,
0,
'No guarantors added when empty relationship passed and not defined'
);
$relationship = 'father1';
$relationship_1->relationship($relationship)->store;
is( Koha::Patron::Relationships->search( { guarantee_id => $patron_1->borrowernumber } )->count,
1,
@ -108,5 +124,17 @@ subtest 'store() tests' => sub {
);
}
t::lib::Mocks::mock_preference( 'borrowerRelationship', '' );
my $relationship_3 = Koha::Patron::Relationship->new(
{
guarantor_id => $patron_1->borrowernumber,
guarantee_id => $patron_2->borrowernumber,
relationship => ''
}
)->store();
is( $relationship_3->relationship, '', 'Empty relationship allowed' );
$schema->storage->txn_rollback;
};