Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32350: Add subtest for bad columns

Browse source 
Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 46aa87c600)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2022-11-25 10:09:57 +00:00 committed by Martin Renvoize
parent abe130e057
commit f7541837f6
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
t/db_dependent/TestBuilder.t
View file

@ -21,8 +21,9 @@ use Modern::Perl;
use utf8;
use Test::More tests => 15;
use Test::More tests => 16;
use Test::Warn;
use Try::Tiny;
use File::Basename qw(dirname);
use Koha::Database;
@ -544,3 +545,35 @@ subtest 'Existence of object is only checked using primary keys' => sub {
$schema->storage->txn_rollback;
};
subtest 'Test bad columns' => sub {
plan tests => 3;
$schema->storage->txn_begin;
try {
my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { wrong => 1 } });
ok( 0, 'Unexpected pass with wrong column' );
}
catch {
like( $_, qr/^Error: value hash contains unrecognized columns: wrong/, 'Column wrong is bad' );
};
try {
my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { surname => 'Pass', nested => { ignored => 1 }} });
ok( 1, 'Nested hash ignored' );
}
catch {
ok( 0, 'Unexpected trouble with nested hash' );
};
try {
my $patron = $builder->build_object({
class => 'Koha::Patrons',
value => { surname => 'WontPass', categorycode => { description => 'bla', wrong_nested => 1 }},
});
ok( 0, 'Unexpected pass with wrong nested column' );
}
catch {
like( $_, qr/^Error: value hash contains unrecognized columns: wrong_nested/, 'Column wrong_nested is bad' );
};
$schema->storage->txn_rollback;
};