Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23463: Replace recently added occurrences

Browse source 
Few occurrences have been added since this patchset has been originaly
written

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-12-02 12:02:28 +01:00 committed by Martin Renvoize
parent 22f8584ead
commit f76a75a3d3
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
4 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Checkout.pm
View file

@ -137,7 +137,7 @@ sub claim_returned {
)->store();
my $ClaimReturnedLostValue = C4::Context->preference('ClaimReturnedLostValue');
C4::Items::ModItem( { itemlost => $ClaimReturnedLostValue }, undef, $self->itemnumber );
$self->item->itemlost($ClaimReturnedLostValue)->store;
my $ClaimReturnedChargeFee = C4::Context->preference('ClaimReturnedChargeFee');
$charge_lost_fee =

10
Koha/Item.pm
View file

@ -603,16 +603,6 @@ sub current_holds {
return Koha::Holds->_new_from_dbic($hold_rs);
}
=head3 holds
=cut
sub holds {
my ( $self ) = @_;
my $hold_rs = $self->_result->reserves->search;
return Koha::Holds->_new_from_dbic($hold_rs);
}
=head3 stockrotationitem
my $sritem = Koha::Item->stockrotationitem;

2
t/db_dependent/Circulation.t
View file

@ -3007,7 +3007,7 @@ subtest 'Cancel transfers on lost items' => sub {
is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origin branch before it is marked as lost' );
#Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch
ModItem( { itemlost => 1 }, $item->biblionumber, $item->itemnumber );
$item->itemlost(1)->store;
LostItem( $item->itemnumber, 'test', 1 );
($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled');

4
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
View file

@ -68,11 +68,11 @@ subtest 'after_biblio_action() and after_item_action() hooks tests' => sub {
qr/after_item_action called with action: create, ref: Koha::Item/,
'AddItem calls the hook with action=create';
warning_like { C4::Items::ModItem({ location => 'shelves' }, $biblio_id, $item->itemnumber); }
warning_like { $item->location('shelves')->store; }
qr/after_item_action called with action: modify, ref: Koha::Item/,
'ModItem calls the hook with action=modify';
warning_like { C4::Items::DelItem({ itemnumber => $item->itemnumber }); }
warning_like { $item->delete; }
qr/after_item_action called with action: delete/,
'DelItem calls the hook with action=delete, item_id passed';