Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices

Browse source 
This patch fixes two recalls notices which are referencing old column
names, so they leave empty fields when the notices are generated.

To test:

1) Apply database updates and restart services
2) Go to Tools -> Notices
3) Find the RECALL_REQUESTER_DET notice, open the Print tab
4) Confirm there are no references to recalls.waitingdate or
recalls.recallnotes. Confirm the reference is fixed to
recalls.waiting_date and recalls.notes
5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab
6) Confirm there are no references to recalls.branchcode or
recalls.expirationdate. Confirm the reference is fixed to
recalls.pickup_library_id and recalls.expiration_date

Sponsored-by: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=32697
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Aleisha Amohia 2023-02-15 15:15:15 +13:00 committed by Tomas Cohen Arazi
parent cf06f05ec0
commit f7e05c3263
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
installer/data/mysql/atomicupdate/bug_32967_-_fix_recalls_notices.pl Executable file
View file

@ -0,0 +1,20 @@
use Modern::Perl;
return {
bug_number => "32967",
description => "Recalls notices are using the wrong database columns",
up => sub {
my ($args) = @_;
my ($dbh, $out) = @$args{qw(dbh out)};
$dbh->do(q{ UPDATE letter SET content=REPLACE(content,'recalls.branchcode','recalls.pickup_library_id') WHERE code='PICKUP_RECALLED_ITEM' });
$dbh->do(q{ UPDATE letter SET content=REPLACE(content,'recalls.expirationdate','recalls.expiration_date') WHERE code='PICKUP_RECALLED_ITEM' });
say $out "Fix column names in PICKUP_RECALLED_ITEM notice";
$dbh->do(q{ UPDATE letter SET content=REPLACE(content,'recalls.waitingdate','recalls.waiting_date') WHERE code='RECALL_REQUESTER_DET' });
$dbh->do(q{ UPDATE letter SET content=REPLACE(content,'recalls.recallnotes','recalls.notes') WHERE code='RECALL_REQUESTER_DET' });
say $out "Fix column names in RECALL_REQUESTER_DET notice";
},
};

6
installer/data/mysql/en/mandatory/sample_notices.yml
View file

@ -2031,7 +2031,7 @@ tables:
- ""
- "<<borrowers.firstname>> <<borrowers.surname>>,"
- ""
- "A recall that you requested on the following item: <<biblio.title>> / <<biblio.author>> (<<items.barcode>>) is now ready for you to pick up at <<recalls.branchcode>>. Please pick up your item by <<recalls.expirationdate>>."
- "A recall that you requested on the following item: <<biblio.title>> / <<biblio.author>> (<<items.barcode>>) is now ready for you to pick up at <<recalls.pickup_library_id>>. Please pick up your item by <<recalls.expiration_date>>."
- ""
- "Thank you!"
@ -2056,8 +2056,8 @@ tables:
- "<<biblio.title>> by <<biblio.author>>"
- "Barcode: <<items.barcode>>"
- "Callnumber: <<items.itemcallnumber>>"
- "Waiting since: <<recalls.waitingdate>>"
- "Notes: <<recalls.recallnotes>>"
- "Waiting since: <<recalls.waiting_date>>"
- "Notes: <<recalls.notes>>"
- module: members
code: 2FA_DISABLE