Bug 18036: Perlcritic improve t/db_dependent/Templates.t

TEST PLAN
---------
1) apply 17982
2) perlcritic -3 t/db_dependent/Templates.t
   -- messages
3) apply this patch
4) perlcritic -3 t/db_dependent/Templates.t
   -- OK
5) run koha qa test tools

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Mark Tompsett 2017-02-02 12:16:01 -05:00 committed by Kyle M Hall
parent ad707d0274
commit f7eca64f80

View file

@ -43,10 +43,10 @@ my $columns = C4::Templates::GetColumnDefs( $query );
is( ref( $columns ) eq 'HASH', 1, 'GetColumnDefs returns a hashref' );
# get the tables names, sorted
my @keys = sort keys %$columns;
is( scalar @keys, 6, "GetColumnDefs correctly returns the 5 tables defined in columns.def" );
my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics', 'subscription');
cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables");
my @keys = sort keys %{$columns};
is( scalar @keys, 6, 'GetColumnDefs correctly returns the 5 tables defined in columns.def' );
my @tables = qw( biblio biblioitems borrowers items statistics subscription );
cmp_deeply( \@keys, \@tables, 'GetColumnDefs returns the expected tables');
subtest 'Testing themelanguage for unique themes (BZ 17982)' => sub {
plan tests => 1;