Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23591: Hide archived suggestions

Browse source 
However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-11-19 17:35:09 +01:00 committed by Martin Renvoize
parent 97876fa76d
commit f843e8be51
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
catalogue/detail.pl
View file

@ -250,12 +250,14 @@ if ( C4::Context->preference('suggestion') ) {
my $suggestions = Koha::Suggestions->search(
{
biblionumber => $biblionumber,
archived => 0,
},
{
order_by => { -desc => 'suggesteddate' }
}
);
$template->param( suggestions => $suggestions );
my $nb_archived_suggestions = Koha::Suggestions->search({ biblionumber => $biblionumber, archived => 1 })->count;
$template->param( suggestions => $suggestions, nb_archived_suggestions => $nb_archived_suggestions );
}
if ( defined $dat->{'itemtype'} ) {

5
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View file

@ -6,6 +6,7 @@
[% USE Branches %]
[% USE Biblio %]
[% USE ColumnsSettings %]
[% PROCESS 'i18n.inc' %]
[% SET AdlibrisEnabled = Koha.Preference('AdlibrisCoversEnabled') %]
[% SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') %]
@ -698,6 +699,9 @@ Note that permanent location is a code, and location may be an authval.
[% IF suggestions.count %]
<div id="suggestion_details">
[% IF nb_archived_suggestions > 0 %]
<p>[% tnpx('pluralization', 'There is one archived suggestion.', 'There are {count} archived suggestions.', nb_archived_suggestions, { count = nb_archived_suggestions }) | $raw %]
[% END %]
<table id="suggestions" class="sorted">
<thead>
<tr>
@ -722,7 +726,6 @@ Note that permanent location is a code, and location may be an authval.
[% IF ( suggestion.copyrightdate ) %]&copy; [% suggestion.copyrightdate | html %] [% END %]
[% IF ( suggestion.volumedesc ) %]; Volume:<i>[% suggestion.volumedesc | html %]</i> [% END %]
[% IF ( suggestion.isbn ) %]; ISBN:<i>[% suggestion.isbn | html %]</i> [% END %][% IF ( suggestion.publishercode ) %]; Published by [% suggestion.publishercode | html %] [% END %][% IF ( suggestion.publicationyear ) %] in <i>[% suggestion.publicationyear | html %]</i> [% END %][% IF ( suggestion.place ) %] in <i>[% suggestion.place | html %]</i> [% END %][% IF ( suggestion.collectiontitle ) %]; [% suggestion.collectiontitle | html %] [% END %][% IF ( suggestion.itemtype ) %]; [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestion.itemtype, 0 ) | html %] [% END %]<br />[% IF ( suggestion.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestion.note | html %]</div>[% END %]
[% IF suggestion.archived %]<br /><i class="fa fa-archive"> Archived[% END %]
</td>
<td>
<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestion.suggestedby | uri %]">[% INCLUDE 'patron-title.inc' patron => suggestion.suggester %]</a>