Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21999: Move attributes to a variable to not dup them

Browse source 
Avoid c/p as much as possible :)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-12-17 18:26:47 -03:00 committed by Nick Clemens
parent eb979680d7
commit f8544ba579
1 changed files with 13 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
C4/Circulation.pm
View file

@ -1356,30 +1356,24 @@ sub AddIssue {
}
$datedue->truncate( to => 'minute' );
$issue =
Koha::Checkouts->find( { itemnumber => $item->{'itemnumber'} } );
my $issue_attributes = {
borrowernumber => $borrower->{'borrowernumber'},
issuedate => $issuedate->strftime('%Y-%m-%d %H:%M:%S'),
date_due => $datedue->strftime('%Y-%m-%d %H:%M:%S'),
branchcode => C4::Context->userenv->{'branch'},
onsite_checkout => $onsite_checkout,
auto_renew => $auto_renew ? 1 : 0,
};
$issue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
if ($issue) {
$issue->set(
{
borrowernumber => $borrower->{'borrowernumber'},
issuedate => $issuedate->strftime('%Y-%m-%d %H:%M:%S'),
date_due => $datedue->strftime('%Y-%m-%d %H:%M:%S'),
branchcode => C4::Context->userenv->{'branch'},
onsite_checkout => $onsite_checkout,
auto_renew => $auto_renew ? 1 : 0
}
)->store;
$issue->set($issue_attributes)->store;
}
else {
$issue = Koha::Checkout->new(
{
borrowernumber => $borrower->{'borrowernumber'},
itemnumber => $item->{'itemnumber'},
issuedate => $issuedate->strftime('%Y-%m-%d %H:%M:%S'),
date_due => $datedue->strftime('%Y-%m-%d %H:%M:%S'),
branchcode => C4::Context->userenv->{'branch'},
onsite_checkout => $onsite_checkout,
auto_renew => $auto_renew ? 1 : 0
itemnumber => $item->{itemnumber},
%$issue_attributes,
}
)->store;
}