Browse Source

Bug 28750: (bug 17600 follow-up) Use full path for subroutines

Throughout the file we call methods with the module
Following suit rather than importing the methods

To test:
1 - Attempt to load advanced cataloging editor
2 - it fails
3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define
4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18
5 - Apply patch
6 - Cataloging editor loads!
7 - Link in #3 loads!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
21.11.x
Nick Clemens 3 years ago
committed by Jonathan Druart
parent
commit
f8813f8d37
  1. 4
      svc/cataloguing/framework

4
svc/cataloguing/framework

@ -15,7 +15,7 @@ my ( $query, $response ) = C4::Service->init( editcatalogue => 'edit_catalogue'
my $frameworkcode = $query->param( 'frameworkcode' ) // '';
my $tagslib = GetMarcStructure( 1, $frameworkcode );
my $tagslib = C4::Biblio::GetMarcStructure( 1, $frameworkcode );
my @tags;
@ -42,7 +42,7 @@ $authorised_values->{itemtypes} = [ $schema->resultset( "Itemtype" )->search( un
result_class => 'DBIx::Class::ResultClass::HashRefInflator'
} ) ];
my $class_sources = GetClassSources();
my $class_sources = C4::ClassSource::GetClassSources();
my $default_source = C4::Context->preference("DefaultClassificationSource");

Loading…
Cancel
Save