Browse Source

Bug 16717: Improve variable naming

$category was a categorycode, to help the readability it's better to
name it $categorycode or assign a Category to $category

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
16.11.x
Jonathan Druart 7 years ago
committed by Kyle M Hall
parent
commit
f8b73deaec
  1. 4
      t/db_dependent/Holds.t

4
t/db_dependent/Holds.t

@ -34,7 +34,7 @@ my $dbh = C4::Context->dbh;
my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
my $category = $builder->build({ source => 'Category' })->{categorycode};
my $category = $builder->build({ source => 'Category' });
my $borrowers_count = 5;
@ -60,7 +60,7 @@ foreach (1..$borrowers_count) {
my $borrowernumber = AddMember(
firstname => 'my firstname',
surname => 'my surname ' . $_,
categorycode => $category,
categorycode => $category->{categorycode},
branchcode => $branch_1,
);
push @borrowernumbers, $borrowernumber;

Loading…
Cancel
Save