Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23050: Fix tab's id to avoid compatibility issues

Browse source 
MDN says:

  Using characters except ASCII letters, digits, '_', '-' and '.' may
  cause compatibility problems, as they weren't allowed in HTML 4.
  Though this restriction has been lifted in HTML5, an ID should start
  with a letter for compatibility.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Julian Maurice 2019-07-15 14:28:47 +02:00 committed by Martin Renvoize
parent 00db9a7624
commit f981da7494
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
catalogue/detail.pl
View file

@ -77,8 +77,8 @@ if ( C4::Context->preference('UseKohaPlugins') &&
foreach my $tab_plugin (@tab_plugins) { foreach my $tab_plugin (@tab_plugins) {
my @biblio_tabs = $tab_plugin->intranet_catalog_biblio_tab(); my @biblio_tabs = $tab_plugin->intranet_catalog_biblio_tab();
foreach my $tab (@biblio_tabs) { foreach my $tab (@biblio_tabs) {
$tab->{id} = $tab->{title}; $tab->{id} = 'tab-' + $tab->{title};
$tab->{id} =~ s/[^\w]+/-/g; $tab->{id} =~ s/[^0-9A-Za-z]+/-/g;
push @tabs, $tab, push @tabs, $tab,
} }
} }