Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

Browse source 
Since auth_tag_structure.pl redirects after deleting when the op is
delete_confirmed (which is actually cud-delete_confirmed) rather than loading
the template, there's no reason to have dead code for IF ( delete_confirmed )
which is both never set, and is never called when anything like it is set.

Test plan:
1. With the patch applied, Administration - Authority types - Chronological
   Term row - Actions menu - MARC Structure
2. You've already verified that auth_tag_structure.tt isn't malformed, but for
   extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that
   it was deleted

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Phil Ringnalda 2024-06-22 15:57:01 -07:00 committed by Katrin Fischer
parent 825c6c5edf
commit f9e602ce98
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
View file

@ -16,9 +16,6 @@
[% IF ( delete_confirm ) %] [% IF ( delete_confirm ) %]
[% tx("Confirm deletion of tag '{searchfield}'", { searchfield = searchfield }) | html %] &rsaquo; [% tx("Confirm deletion of tag '{searchfield}'", { searchfield = searchfield }) | html %] &rsaquo;
[% END %] [% END %]
[% IF ( delete_confirmed ) %]
[% t("Data deleted") | html %] &rsaquo;
[% END %]
[% IF ( authtypecode ) %] [% IF ( authtypecode ) %]
[% tx("'{authtypecode}' framework", { authtypecode = authtypecode }) | html %] [% tx("'{authtypecode}' framework", { authtypecode = authtypecode }) | html %]
[% ELSE %] [% ELSE %]
@ -46,7 +43,7 @@
<a href="/cgi-bin/koha/admin/authtypes.pl">Authority types</a> <a href="/cgi-bin/koha/admin/authtypes.pl">Authority types</a>
[% END %] [% END %]
[% IF ( add_form || delete_confirm || delete_confirmed ) %] [% IF ( add_form || delete_confirm ) %]
[% IF ( authtypecode ) %] [% IF ( authtypecode ) %]
[% WRAPPER breadcrumb_item %] [% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=[% authtypecode | uri %]">[% tx("'{authtypecode}' framework", { authtypecode = authtypecode }) | html %]</a> <a href="/cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=[% authtypecode | uri %]">[% tx("'{authtypecode}' framework", { authtypecode = authtypecode }) | html %]</a>
@ -84,19 +81,13 @@
[% tx("Confirm deletion of tag '{searchfield}'", { searchfield = searchfield }) | html %] [% tx("Confirm deletion of tag '{searchfield}'", { searchfield = searchfield }) | html %]
[% END %] [% END %]
[% ELSE %] [% ELSE %]
[% IF ( delete_confirmed ) %] [% IF ( authtypecode ) %]
[% WRAPPER breadcrumb_item bc_active= 1 %] [% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Data deleted</span> [% tx("{authtypecode} framework", { authtypecode = authtypecode }) | html %]
[% END %] [% END %]
[% ELSE %] [% ELSE %]
[% IF ( authtypecode ) %] [% WRAPPER breadcrumb_item bc_active= 1 %]
[% WRAPPER breadcrumb_item bc_active= 1 %] <span>Default framework</span>
[% tx("{authtypecode} framework", { authtypecode = authtypecode }) | html %]
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Default framework</span>
[% END %]
[% END %] [% END %]
[% END %] [% END %]