Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12753: Warnings in t/SIP_Sip.t could be tested

Browse source 
A C4::SIP warning is expected and should be tested.

To test:
- Run
  $ prove -v t/SIP_Sip.t
=> FAIL: A warning is printed to STDOUT
- Apply the patch
- Run
  $ prove -v t/SIP_Sip.t
=> SUCCESS: No warnings on STDOUT, a new test verifying the warning is added.
- It was an easy one, smile and sign off :-D

Sponsored-by: The Will to Procrastinate
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Sponsored-by: Sunday TV is boring
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Sponsored-by: Avoiding distance study homework
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Tomás Cohen Arazi 2014-08-12 19:34:34 -03:00
parent 7706ba9df4
commit fa678fa241
1 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
t/SIP_Sip.t
View file

@ -1,12 +1,24 @@
#!/usr/bin/perl #!/usr/bin/perl
# This file is part of Koha.
# #
# This Koha test module is a stub! # Koha is free software; you can redistribute it and/or modify it
# Add more tests here!!! # under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict; use Modern::Perl;
use warnings;
use Test::More tests => 8; use Test::More tests => 9;
use Test::Warn;
BEGIN { BEGIN {
use FindBin; use FindBin;
@ -39,5 +51,10 @@ my $something = Sip::Checksum::checksum($testdata);
$something = sprintf("%4X", $something); $something = sprintf("%4X", $something);
ok( Sip::Checksum::verify_cksum($testdata.$something), "Checksum: $something is valid."); ok( Sip::Checksum::verify_cksum($testdata.$something), "Checksum: $something is valid.");
my $invalidTest = Sip::Checksum::verify_cksum("1234567"); my $invalidTest;
warning_is { $invalidTest = Sip::Checksum::verify_cksum("1234567") }
'verify_cksum: no sum detected',
'verify_cksum prints the expected warning for an invalid checksum';
is($invalidTest, 0, "Checksum: 1234567 is invalid as expected"); is($invalidTest, 0, "Checksum: 1234567 is invalid as expected");
1;