Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 19532: (follow-up) aria-hidden attr on OPAC, and more

Browse source 
- removing authnotrequired flag from scripts
- fixing opac buttons
- chmod +x for recalls test files

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Aleisha Amohia 2020-10-24 13:42:05 +13:00 committed by Fridolin Somers
parent db095c3a7b
commit fa7d9815b3
15 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
View file

@ -12,7 +12,7 @@
[% END %] [% END %]
[% IF Koha.Preference('UseRecalls') %] [% IF Koha.Preference('UseRecalls') %]
<li><a class="recall btn btn-link btn-lg" href="/cgi-bin/koha/opac-recall.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-fw fa-bookmark-o"></i> <li><a class="recall btn btn-link btn-lg" href="/cgi-bin/koha/opac-recall.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-fw fa-bookmark-o" aria-hidden="true"></i>
Place recall</a></li> Place recall</a></li>
[% END %] [% END %]

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
View file

@ -151,7 +151,7 @@
<fieldset class="action"> <fieldset class="action">
<input type="hidden" name="op" value="request"> <input type="hidden" name="op" value="request">
<input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html %]"> <input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html %]">
<input type="submit" class="btn" value="Confirm"> <input type="submit" class="btn btn-primary" value="Confirm">
<a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]" class="cancel">Cancel</a> <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]" class="cancel">Cancel</a>
</fieldset> </fieldset>
</form> </form>

4
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
View file

@ -816,7 +816,7 @@
<input type="hidden" name="op" value="cancel"> <input type="hidden" name="op" value="cancel">
<input type="hidden" name="recall_id" value="[% RECALL.recall_id | html %]"> <input type="hidden" name="recall_id" value="[% RECALL.recall_id | html %]">
<input type="hidden" name="biblionumber" value="[% RECALL.biblionumber | html %]"> <input type="hidden" name="biblionumber" value="[% RECALL.biblionumber | html %]">
<button type="submit" name="submit" class="btn btn-sm btn-danger" id="cancel_recall"><i class="icon-remove icon-white"></i> Cancel</button> <button type="submit" name="submit" class="btn btn-sm btn-danger cancel_recall"><i class="fa fa-remove" aria-hidden="true"></i> Cancel</button>
</form> </form>
[% END %] [% END %]
</td> </td>
@ -1205,7 +1205,7 @@
}); });
} }
$("#cancel_recall").click(function(e){ $(".cancel_recall").click(function(e){
return confirmDelete(_("Are you sure you want to remove this recall?")); return confirmDelete(_("Are you sure you want to remove this recall?"));
}); });

1
members/recallshistory.pl
View file

@ -27,7 +27,6 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user(
template_name => "members/recallshistory.tt", template_name => "members/recallshistory.tt",
query => $input, query => $input,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => 1 }, flagsrequired => { recalls => 1 },
debug => 1, debug => 1,
} }

1
opac/opac-recall.pl
View file

@ -29,7 +29,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
template_name => "opac-recall.tt", template_name => "opac-recall.tt",
query => $query, query => $query,
type => "opac", type => "opac",
authnotrequired => 0,
} }
); );

1
opac/opac-recalls.pl
View file

@ -29,7 +29,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
template_name => "opac-recalls.tt", template_name => "opac-recalls.tt",
query => $input, query => $input,
type => "opac", type => "opac",
authnotrequired => 0,
} }
); );

1
recalls/recall_pickup_slip.pl
View file

@ -30,7 +30,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "circ/printslip.tt", template_name => "circ/printslip.tt",
query => $input, query => $input,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { circulate => "circulate_remaining_permissions" }, flagsrequired => { circulate => "circulate_remaining_permissions" },
} }
); );

1
recalls/recalls_old_queue.pl
View file

@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
template_name => "recalls/recalls_old_queue.tt", template_name => "recalls/recalls_old_queue.tt",
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => "manage_recalls" }, flagsrequired => { recalls => "manage_recalls" },
debug => 1, debug => 1,
} }

1
recalls/recalls_overdue.pl
View file

@ -29,7 +29,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
template_name => "recalls/recalls_overdue.tt", template_name => "recalls/recalls_overdue.tt",
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => "manage_recalls" }, flagsrequired => { recalls => "manage_recalls" },
debug => 1, debug => 1,
} }

1
recalls/recalls_queue.pl
View file

@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
template_name => "recalls/recalls_queue.tt", template_name => "recalls/recalls_queue.tt",
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => 'manage_recalls' }, flagsrequired => { recalls => 'manage_recalls' },
debug => 1, debug => 1,
} }

1
recalls/recalls_to_pull.pl
View file

@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
template_name => "recalls/recalls_to_pull.tt", template_name => "recalls/recalls_to_pull.tt",
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => 'manage_recalls' }, flagsrequired => { recalls => 'manage_recalls' },
debug => 1, debug => 1,
} }

1
recalls/recalls_waiting.pl
View file

@ -31,7 +31,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
template_name => "recalls/recalls_waiting.tt", template_name => "recalls/recalls_waiting.tt",
query => $query, query => $query,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => "manage_recalls" }, flagsrequired => { recalls => "manage_recalls" },
debug => 1, debug => 1,
} }

1
recalls/request.pl
View file

@ -30,7 +30,6 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user(
template_name => "recalls/request.tt", template_name => "recalls/request.tt",
query => $input, query => $input,
type => "intranet", type => "intranet",
authnotrequired => 0,
flagsrequired => { recalls => "manage_recalls" }, flagsrequired => { recalls => "manage_recalls" },
debug => 1, debug => 1,
} }

0
t/db_dependent/Koha/Recall.t Normal file → Executable file
View file

0
t/db_dependent/Koha/Recalls.t Normal file → Executable file
View file