Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 9755: (follow-up) tweak test for tag visibility in merge hash

Browse source 
Koha's MARC framework structure doesn't assign tags to tabs in
the cataloging editor; only subfields are assigned to tabs, and
the field as a whole follows the subfields.

Consequently, for the purpoase of calculating a merge hash, a field
should be added either if no MARC framework information is passed
(which signals that the caller wants to deal with the entire MARC
record) or if any of its subfields are assigned to visible tabs.

This patch has the effect of getting rid of the following spurious
warnings from the Apache log:

merge.pl: Argument "" isn't numeric in numeric ge (>=) at /home/gmc/koha/Koha/Util/MARC.pm line 78

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2013-07-23 23:03:31 +00:00
parent 4712fc66f0
commit faa43031e6
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Koha/Util/MARC.pm
View file

@ -75,8 +75,7 @@ sub createMergeHash {
}
if ( ( !defined($tagslib) || $tagslib->{$fieldtag}->{'tab'} >= 0 )
&& @subfield_array )
if ( !defined($tagslib) || @subfield_array )
{
push @array,
{