Bug 29867: Reindent authorized values administration template

This patch performs general template cleanup to authorized values
administration: Make indentation consistent, replace tabs with spaces,
and trim trailing whitespace.

To test, apply the patch and go to Administration -> Authorized values.
Test that all functionality works correctly:

 - Adding or deleting categories
 - Adding, editing, and deleting authorized values.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Owen Leonard 2022-01-12 18:44:28 +00:00 committed by Fridolin Somers
parent 4eec446302
commit fb1213a396

View file

@ -8,7 +8,6 @@
[% IF ( action_add_value ) %]New authorized value &rsaquo; [% END %]
[% IF ( action_add_category ) %]New category &rsaquo; [% END %]
[% END %]
Authorized values &rsaquo; Administration &rsaquo; Koha
</title>
[% INCLUDE 'doc-head-close.inc' %]
@ -93,18 +92,25 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
[% IF ( action_add_category ) %]New category[% END %]
</h1>
[% IF ( action_modify ) %]<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %]
[% IF ( action_modify ) %]
<div class="note">
<i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.
</div>
[% END %]
<form action="/cgi-bin/koha/admin/authorised_values.pl" name="Aform" method="post" class="validated">
<fieldset class="rows"><ol>
<fieldset class="rows">
[% IF action_add_category %]
<ol>
<li>
<label for="category" class="required">Category: </label>
<input type="text" name="category" id="category" size="32" maxlength="32" class="focus required" />
<span class="required">Required</span>
<input type="hidden" name="op" value="add_category" />
</li>
</ol>
[% ELSE %]
<ol>
<li>
<span class="label">Category</span>
<input type="hidden" name="op" value="add" />
@ -112,7 +118,9 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
</li>
<li>
<label for="authorised_value">Authorized value: </label>
[% IF ( action_modify ) %]<input type="hidden" id="id" name="id" value="[% id | html %]" />[% END %]
[% IF ( action_modify ) %]
<input type="hidden" id="id" name="id" value="[% id | html %]" />
[% END %]
<input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value | html %]" maxlength="80" class="focus" />
</li>
<li>
@ -138,6 +146,7 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
</li>
</ol>
<div id="icons" class="toptabs" style="clear:both">
<h5 style="margin-left:10px;">Choose an icon:</h5>
<ul>
@ -146,41 +155,52 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
[% IF ( imageset.imagesetactive ) %]<li class="ui-tabs-active">[% ELSE %]<li>[% END %]<a href="#[% imageset.imagesetname | uri %]">[% imageset.imagesetname | html %]</a></li>
[% END %]
</ul>
<div id="none"><ul>
<li><label for="noimage">No image: </label><input type="radio" name="imageurl" id="noimage" value="removeImage" /></li>
<div id="none">
<ul>
<li>
<label for="noimage">No image: </label><input type="radio" name="imageurl" id="noimage" value="removeImage" />
</li>
</ul>
<br class="clear" /></div>
<br class="clear" />
</div>
[% FOREACH imageset IN imagesets %]
<div id="[% imageset.imagesetname | html %]"><ul>
<div id="[% imageset.imagesetname | html %]">
<ul>
[% FOREACH image IN imageset.images %]
<li style="float: none; display: inline-block; clear : none; width: auto;">
<label> [% IF ( image.StaffImageUrl ) %]
<label>
[% IF ( image.StaffImageUrl ) %]
<img src="[% image.StaffImageUrl | html %]" alt="[% image.StaffImageUrl | html %]" title="[% image.StaffImageUrl | html %]" />
[% ELSE %]
[% END %]
[% IF ( image.checked ) %]
<input type="radio" name="imageurl" value="[% image.KohaImage | html %]" checked="checked" />
[% ELSE %]
[% IF ( image.KohaImage ) %] <!-- to delete the radio button if there is no image after -->
[% IF ( image.KohaImage ) %]
<!-- to delete the radio button if there is no image after -->
<input type="radio" name="imageurl" value="[% image.KohaImage | html %]" />
[% END %]
[% END %]
</label>
</li>
[% END %]</ul>
[% END %]
</ul>
<br class="clear" />
</div>
[% END %]
</div>
[% END %]
</fieldset>
<fieldset class="action"> <input type="hidden" name="id" value="[% id | html %]" />
<input type="submit" value="Save" /> <a class="cancel" href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=[% category_name | url %]">Cancel</a></fieldset>
<fieldset class="action">
<input type="hidden" name="id" value="[% id | html %]" />
<input type="submit" value="Save" />
<a class="cancel" href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=[% category_name | url %]">Cancel</a>
</fieldset>
</form>
[% END %]
[% IF op == 'list' %]
<div id="toolbar" class="btn-toolbar">
<a id="addcat" class="btn btn-default" href= "/cgi-bin/koha/admin/authorised_values.pl?op=add_form"><i class="fa fa-plus"> </i> New category</a>
[% IF ( searchfield ) %]
@ -252,9 +272,9 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
</form>
[% IF loop %]
<table id="categoriest" class="authorized_values_table">
<thead><tr>
<thead>
<tr>
<th>Authorized value</th>
<th>Description</th>
<th>Description (OPAC)</th>
@ -262,13 +282,15 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
<th>Library limitations</th>
<th class="noExport NoSort">Actions</th>
</tr>
</thead><tbody>
</thead>
<tbody>
[% FOREACH loo IN loop %]
<tr>
<td>[% loo.authorised_value | html %]</td>
<td>[% loo.lib | html %]</td>
<td>[% loo.lib_opac | html %]</td>
<td>[% IF ( loo.imageurl ) %]<img src="[% loo.imageurl | url %]" alt=""/>[% ELSE %]&nbsp;[% END %]</td>
<td>
[% IF ( loo.imageurl ) %]<img src="[% loo.imageurl | url %]" alt=""/>[% ELSE %]&nbsp;[% END %]</td>
<td>
[% IF loo.branches.size > 0 %]
[% branches_str = "" %]
@ -293,7 +315,8 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
<a class="delete btn btn-default btn-xs" href="/cgi-bin/koha/admin/authorised_values.pl?op=delete&amp;searchfield=[% searchfield | uri %]&amp;id=[% loo.id | uri %]"><i class="fa fa-trash"></i> Delete</a></td>
</tr>
[% END # /FOREACH loop %]
</tbody></table>
</tbody>
</table>
[% ELSE %]
<div class="dialog message">
<p>There are no authorized values defined for [% category.category_name | html %]</p>
@ -336,6 +359,7 @@ Authorized values &rsaquo; Administration &rsaquo; Koha
[% END %]
</tbody>
</table>
[% END # /IF ( searchfield )%]
[% END # /IF op == 'list' %]