Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33205: (bug 28268 follow-up) Method call $row->authid inside quotes - produces meaningless warning

Browse source 
Bug 28268, in
Koha::MetadataRecord::Authority::get_all_authorities_iterator,
introduced a warning:

warn "Something went wrong reading record for authority $row->authid: $@\n";

But a method cannot be called from within quotes in Perl - extrapolation
does not work for functions/methods.  So, if something really goes
wrong, this line of code produces a warning like:

Something went wrong reading record for authority
Koha::Schema::Result::AuthHeader=HASH(0x55cf7e0d0958)->authid: Empty
String at /usr/share/perl5/MARC/File/XML.pm line 450.

which is not very informative -- authid is missing.

Test plan
=========
Hard to reproduce.  This problem occurs only in rare cases of some weird problem
in stores authority data or if a auth record had been deleted after a ES reindex
action has been initiated.  But the problem in the code and the fix seem obvious.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 9c2510ea2e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Janusz Kaczmarek 2023-03-11 11:45:32 +01:00 committed by Fridolin Somers
parent 7c4ea8ee7f
commit fb3473dfe3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/MetadataRecord/Authority.pm
View file

@ -209,7 +209,7 @@ sub get_all_authorities_iterator {
my $auth = __PACKAGE__->get_from_authid($row->authid);
if (!$auth) {
warn "Something went wrong reading record for authority $row->authid: $@\n";
warn "Something went wrong reading record for authority " . $row->authid . ": $@\n";
next;
}
return $auth;