Bug 4068: (follow-up) use URI::Escape

This allows for suggestions that contain characters such
as the ampersand to have their status changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2014-05-08 16:36:10 +00:00
parent 769f18a6a9
commit fb8d47beda

View file

@ -31,6 +31,7 @@ use C4::Search;
use C4::Dates qw(format_date); use C4::Dates qw(format_date);
use C4::Members; use C4::Members;
use C4::Debug; use C4::Debug;
use URI::Escape;
sub Init{ sub Init{
my $suggestion= shift @_; my $suggestion= shift @_;
@ -182,7 +183,7 @@ elsif ($op eq "change" ) {
$$suggestion_ref{'suggestionid'}=$suggestionid; $$suggestion_ref{'suggestionid'}=$suggestionid;
&ModSuggestion($suggestion_ref); &ModSuggestion($suggestion_ref);
} }
my $params; my $params = '';
foreach my $key ( foreach my $key (
qw( qw(
displayby branchcode title author isbn publishercode copyrightdate displayby branchcode title author isbn publishercode copyrightdate
@ -192,8 +193,8 @@ elsif ($op eq "change" ) {
) )
) )
{ {
$params .= $key . '=' . $input->param($key) . '&' $params .= $key . '=' . uri_escape($input->param($key)) . '&'
if $input->param($key); if defined($input->param($key));
} }
print $input->redirect("/cgi-bin/koha/suggestion/suggestion.pl?$params"); print $input->redirect("/cgi-bin/koha/suggestion/suggestion.pl?$params");
}elsif ($op eq "delete" ) { }elsif ($op eq "delete" ) {