Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25172: Remove _recheck_logfile

Browse source 
I don't understand how that could be useful. We do not want to test if
the logfile is writable every time we log something!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2020-04-16 16:12:32 +02:00 committed by Martin Renvoize
parent bfa921665a
commit fb9268417b
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 3 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Koha/Logger.pm
View file

@ -86,17 +86,8 @@ sub AUTOLOAD {
my $method = $Koha::Logger::AUTOLOAD;
$method =~ s/^Koha::Logger:://;
if ( !exists $self->{logger} ) {
#do not use log4perl; no print to stderr
}
elsif ( !$self->_recheck_logfile ) {
warn "Log file not writable for log4perl";
warn "$method: $line" if $line;
}
elsif ( $self->{logger}->can($method) ) { #use log4perl
$self->{logger}->$method($line);
return 1;
if ( $self->{logger}->can($method) ) { #use log4perl
return $self->{logger}->$method($line);
}
else { # we should not really get here
warn "ERROR: Unsupported method $method";
@ -112,7 +103,7 @@ sub AUTOLOAD {
sub DESTROY { }
=head2 _init, _recheck_logfile
=head2 _init
=cut
@ -132,20 +123,6 @@ sub _init {
return Log::Log4perl->init_once($log4perl_config);
}
sub _recheck_logfile { # recheck saved logfile when logging message
my $self = shift;
return 1 if !exists $self->{logs}; # remember? your own responsibility
my $opac = $self->{cat} =~ /^OPAC/;
my $log;
foreach ( @{ $self->{logs} } ) {
$log = $_ if $opac && /^OPAC:/ || !$opac && /^INTRANET:/;
last if $log;
}
$log =~ s/^(OPAC|INTRANET)://;
return -w $log;
}
=head2 debug_to_screen
Adds a new appender for the given logger that will log all DEBUG-and-higher messages to stderr.