Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24446: (QA follow-up) Remove superflous store calls

Browse source 
The original code here called store after setting each field. Instead,
we set all the fields and call store at the end and save ourselves a few
database hits.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2021-02-18 10:54:34 +00:00 committed by Jonathan Druart
parent a82279c362
commit fdaac5394c
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Koha/StockRotationItem.pm
View file

@ -202,14 +202,14 @@ sub advance {
my $stage = $self->stage;
my $new_stage;
if ( $self->indemand && !$self->fresh ) {
$self->indemand(0)->store; # De-activate indemand
$self->indemand(0); # De-activate indemand
$new_stage = $stage;
}
else {
# New to rota?
if ( $self->fresh ) {
$new_stage = $self->stage->first_sibling || $self->stage;
$self->fresh(0)->store; # Reset fresh
$self->fresh(0); # Reset fresh
}
# Last stage?
elsif ( !$stage->last_sibling ) {
@ -229,7 +229,8 @@ sub advance {
}
# Update stage and record transfer
$self->stage_id( $new_stage->stage_id )->store; # Set new stage
$self->stage_id( $new_stage->stage_id ); # Set new stage
$self->store();
$item->homebranch( $new_stage->branchcode_id )->store; # Update homebranch
$transfer = try {
$item->request_transfer(