Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6679: fix missing use strict

Browse source 
The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it
4XX.pl also has some perlcritic fixes:
Variable declared in conditional statement at line XXX, column 9.  Declare variables outside of the condition.  (Severity: 5)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Paul Poulain 2011-12-08 17:13:38 +01:00
parent 7dbb966b49
commit fe50ffb37f
3 changed files with 28 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cataloguing/value_builder/stocknumber.pl
View file

@ -17,8 +17,8 @@
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#use strict;
#use warnings; FIXME - Bug 2505
use strict;
use warnings;
use C4::Context;
=head1 plugin_parameters
@ -53,12 +53,12 @@ sub plugin_javascript {
my $branchcode = C4::Context->userenv->{'branch'};
$query = "SELECT MAX(CAST(SUBSTRING_INDEX(stocknumber,'_',-1) AS SIGNED))+1 FROM items WHERE homebranch = ? AND stocknumber LIKE ?";
my $query = "SELECT MAX(CAST(SUBSTRING_INDEX(stocknumber,'_',-1) AS SIGNED))+1 FROM items WHERE homebranch = ? AND stocknumber LIKE ?";
my $sth=$dbh->prepare($query);
$sth->execute($branchcode,$branchcode."_%");
my ($nextnum) = $sth->fetchrow;
my $nextnum = $branchcode.'_'.$nextnum;
$nextnum = $branchcode.'_'.$nextnum;
my $scr = <<END_OF_JS;
if (\$('#' + id).val() == '' || force) {

11
cataloguing/value_builder/unimarc_field_210c.pl
View file

@ -18,8 +18,8 @@
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#use strict;
#use warnings; FIXME - Bug 2505
use strict;
use warnings;
use C4::AuthoritiesMarc;
use C4::Auth;
@ -110,7 +110,10 @@ my ($input) = @_;
my $authtypes = getauthtypes;
my @authtypesloop;
foreach my $thisauthtype (keys %$authtypes) {
my $selected = 1 if $thisauthtype eq $authtypecode;
my $selected;
if ($thisauthtype eq $authtypecode) {
$selected=1;
}
my %row =(value => $thisauthtype,
selected => $selected,
authtypetext => $authtypes->{$thisauthtype}{'authtypetext'},
@ -183,7 +186,7 @@ my ($input) = @_;
} else {
$to = (($startfrom+1)*$resultsperpage);
}
my $link="../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_210c.pl&amp;authtypecode=EDITORS&and_or=$and_or&amp;marclist=$marclist&amp;operator=$operator&amp;orderby=$orderby&amp;excluding=$excluding&amp;".join("&amp;",map {"value=".$_} @value)."&amp;op=do_search&amp;type=intranet&amp;index=$index";
my $link="../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_210c.pl&amp;authtypecode=EDITORS&amp;".join("&amp;",map {"value=".$_} @value)."&amp;op=do_search&amp;type=intranet&amp;index=$index";
$template->param(result => $results) if $results;
$template->param('index' => $query->param('index'));

26
cataloguing/value_builder/unimarc_field_4XX.pl
View file

@ -269,8 +269,10 @@ sub plugin {
$subfield_value_t = $marcrecord->field('500')->subfield("a");
}
my $subfield_value_u = $marcrecord->field('856')->subfield("u")
if ( $marcrecord->field('856') );
my $subfield_value_u;
if ( $marcrecord->field('856') ) {
$subfield_value_u = $marcrecord->field('856')->subfield("u");
}
my $subfield_value_v;
if ( ( $marcrecord->field('225') )
@ -283,14 +285,17 @@ sub plugin {
{
$subfield_value_v = $marcrecord->field('200')->subfield("h");
}
my $subfield_value_x = $marcrecord->field('011')->subfield("a")
if (
my $subfield_value_x;
if (
$marcrecord->field('011')
and not( ( $marcrecord->field('011')->subfield("y") )
or ( $marcrecord->field('011')->subfield("z") ) )
);
my $subfield_value_y = $marcrecord->field('013')->subfield("a")
if ( $marcrecord->field('013') );
or ( $marcrecord->field('011')->subfield("z") ) ) ) {
$subfield_value_x = $marcrecord->field('011')->subfield("a");
}
my $subfield_value_y;
if ( $marcrecord->field('013') ) {
$subfield_value_y = $marcrecord->field('013')->subfield("a");
}
if ( $marcrecord->field('010') ) {
$subfield_value_y = $marcrecord->field('010')->subfield("a");
}
@ -374,7 +379,10 @@ sub plugin {
my $record = MARC::Record::new_from_usmarc( $results->[$i] );
my $rechash = TransformMarcToKoha( $dbh, $record );
my $pos;
my $countitems = 1 if ( $rechash->{itemnumber} );
my $countitems;
if ( $rechash->{itemnumber} ) {
$countitems=1;
}
while ( index( $rechash->{itemnumber}, '|', $pos ) > 0 ) {
$countitems += 1;
$pos = index( $rechash->{itemnumber}, '|', $pos ) + 1;