Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32803: EnableItemGroups and EnableItemGroupHolds options are wrong

Browse source 
This patch corrects the options for the EnableItemGroups and
EnableItemGroupHolds system preferences.

To test:
1. Enable EnableItemGroups and EnableItemGroupHolds system preferences
   1.1. Go to Administration > Global system preferences
   1.2. Search for EnableItemGroup (no s, to get both)
   1.3. Enable both EnableItemGroups and EnableItemGroupHolds
   1.4. Click Save all Circulation preferences
2. Go to About Koha > System information
   --> There is a warning message
3. Go to a bibliographic record with at least one item
   --> The item group tab is displayed
4. Create an item group
   4.1. Click New item group
   4.2. Enter a name
   4.3. Click Submit
   4.4. In the Holdings tab, select the item
   4.5. Click on Add/move to item group
   4.6. Click Set item group
5. Place a hold on the item group
   5.1. Click Place hold
   5.2. Search for a patron
   5.3. In the 'Hold next available item from an item group' section, select the item group
   5.4. Click Place hold
   --> Placing a hold is possible
6. Disable EnableItemGroups and EnableItemGroupHolds system preferences
   1.1. Go to Administration > Global system preferences
   1.2. Search for EnableItemGroup (no s, to get both)
   1.3. Disable both EnableItemGroups and EnableItemGroupHolds
   1.4. Click Save all Circulation preferences
7. Go to About Koha > System information
   --> There is a warning message
8. Apply patch
9. Redo steps 1 and 2
   --> There is no warning
10. Redo step 3
   --> The item group tab is displayed
11. Redo steps 4 and 5
   --> Placing a hold is possible
12. Redo steps 6 and 7
   --> There is no warning

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

JD Amended commit message: * Commit title does not start with 'Bug XXXXX: '
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Caroline Cyr La Rose 2023-02-02 12:45:04 -05:00 committed by Tomas Cohen Arazi
parent b3c945dd09
commit fe872b7920
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
View file

@ -673,8 +673,8 @@ Circulation:
-
- pref: EnableItemGroups
choices:
yes: Enable
no: "Don't enable"
1: Enable
0: "Don't enable"
- the item groups feature to allow collecting groups of items on a record together.
-
- In the staff interface, split the holds queue into separate tables by
@ -688,8 +688,8 @@ Circulation:
-
- pref: EnableItemGroupHolds
choices:
yes: Enable
no: "Don't enable"
1: Enable
0: "Don't enable"
- the ability to place holds on item groups.
-
- If the holds queue is split, show librarians