Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29795: add empty value for branchcode on self-reg form

Browse source 
1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField
2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically
3. Fill out the other required fields and the captcha. Don't change the branchcode value.
4. Submit the form, it submits.
5. If branchcode is required it should default to an empty value and force the user to make a choice.
6. Apply patch
7. Repeat 1-3
8. Now you cannot submit the form unless you choose a branchcode
9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Lucas Gass 2022-01-04 22:44:32 +00:00 committed by Fridolin Somers
parent af22b87965
commit feee248de4
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
View file

@ -249,6 +249,9 @@
<label for="borrower_branchcode" class="[% required.branchcode | html %]">Home library:</label> <label for="borrower_branchcode" class="[% required.branchcode | html %]">Home library:</label>
<select id="borrower_branchcode" name="borrower_branchcode" class="[% required.branchcode | html %]"> <select id="borrower_branchcode" name="borrower_branchcode" class="[% required.branchcode | html %]">
[% IF required.branchcode %]
<option value=""></option>
[% END %]
[% FOREACH l IN libraries %] [% FOREACH l IN libraries %]
[% IF l.branchcode == borrower.branchcode %] [% IF l.branchcode == borrower.branchcode %]
<option value="[% l.branchcode | html %]" selected="selected">[% l.branchname | html %]</option> <option value="[% l.branchcode | html %]" selected="selected">[% l.branchname | html %]</option>