Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders

Browse source 
If there are no late orders in the database, the 5th unit test for C4/Acquisition.pm
fails, since no date is returned (and today's date is expected)

This patch adds a conditional check around whether any late orders are actually returned
by GetLateOrders. If so, tests proceed, if not, they're skipped.  This seems to quiet
the failures in the automated test suite.

http://bugs.koha-community.org/show_bug.cgi?id=5347

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This commit is contained in:
Ian Walls 2012-03-19 19:16:48 -04:00 committed by Paul Poulain
parent bee324cec2
commit ff29f978af
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
t/db_dependent/Acquisition.t
View file

@ -33,10 +33,13 @@ my $orders = GetPendingOrders( $supplierid, $grouped );
isa_ok( $orders, 'ARRAY' );
my @lateorders = GetLateOrders(0);
my $order = $lateorders[0];
AddClaim( $order->{ordernumber} );
my $neworder = GetOrder( $order->{ordernumber} );
is( $neworder->{claimed_date}, strftime( "%Y-%m-%d", localtime(time) ), "AddClaim : Check claimed_date" );
SKIP: {
skip 'No Late Orders, cannot test AddClaim', 1 unless @lateorders;
my $order = $lateorders[0];
AddClaim( $order->{ordernumber} );
my $neworder = GetOrder( $order->{ordernumber} );
is( $neworder->{claimed_date}, strftime( "%Y-%m-%d", localtime(time) ), "AddClaim : Check claimed_date" );
}
SKIP: {
skip 'No relevant orders in database, cannot test baskets', 33 unless( scalar @$orders );
@ -56,7 +59,7 @@ SKIP: {
entrydate
firstname
freight
gst
gstrate
listprice
notes
ordernumber