Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons

Browse source 
Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl
But this is not relevant for expired patrons, especially in child categories.
Check should skip expired patrons

1) Set a non-expired patron with invalid age
2) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you see the patron
3) Edit patron to be expired
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you do not see the patron

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] If we do not want to test valid age for expired patrons, you should
obviously test expired first. Reversing the order in the test.
Putting it in the search criteria would be nicer but leads to more
complicated code.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit c26dff61e7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 22674a7ddf)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Fridolin Somers 2023-08-08 21:44:24 -10:00 committed by Matt Blenkinsop
parent 722ce8a403
commit ff6cb81dbe
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
misc/maintenance/search_for_data_inconsistencies.pl
View file

@ -310,7 +310,7 @@ use C4::Biblio qw( GetMarcFromKohaField );
);
my @invalid_patrons;
while ( my $aging_patron = $aging_patrons->next ) {
push @invalid_patrons, $aging_patron unless $aging_patron->is_valid_age;
push @invalid_patrons, $aging_patron unless $aging_patron->is_expired || $aging_patron->is_valid_age;
}
if (@invalid_patrons) {
new_section("Patrons with invalid age for category");