Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32804: (follow-up) Test that id's have not changed

Browse source 
Rather than assuming biblionumber and biblioitemnumber are the same, we
should test that they have not changed form their original values

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 520db70bf1)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2023-03-03 12:18:40 +00:00 committed by Matt Blenkinsop
parent f0fa139b7a
commit ffb1a70343
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
t/db_dependent/ImportBatch.t
View file

@ -361,9 +361,11 @@ subtest "BatchCommitRecords overlay into framework" => sub {
};
subtest "Do not adjust biblionumber when replacing items during import" => sub {
plan tests => 6;
plan tests => 7;
my $item1 = $builder->build_sample_item;
my $original_biblionumber = $item1->biblionumber;
my $original_biblioitemnumber = $item1->biblioitemnumber;
my $item2 = $builder->build_sample_item;
my $library = $builder->build_object({ class => 'Koha::Libraries' });
@ -401,7 +403,8 @@ subtest "Do not adjust biblionumber when replacing items during import" => sub {
is( $import_item->status, 'imported', 'Import was successful');
is( $import_item->import_error, undef, 'No error was reported' );
is( $item1->biblionumber, $item1->biblioitemnumber, "Item's biblionumber and biblioitemnumber match" );
is( $item1->biblionumber, $original_biblionumber, "Item's biblionumber has not changed" );
is( $item1->biblionumber, $original_biblioitemnumber, "Item's biblioitemnumber has not changed" );
is( $item1->homebranch, $library->branchcode, "Item was overlaid successfully" );
};