Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15061: Can't add item to rotating collection

Browse source 
This patch prevents adding items to invalid (empty)
rotating collection id

To test:
1) Go to /cgi-bin/koha/rotating_collections/addItems.pl
2) Try to add an item, you get error show in attached pictures
3) Apply the patch
4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl
5) Can't add any items

I don't know if this is a real problem

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Bernardo Gonzalez Kriegel 2015-11-03 12:16:08 -03:00 committed by Tomas Cohen Arazi
parent c292dde75b
commit fff73a7383
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt
View file

@ -20,8 +20,13 @@
<div id="yui-main">
<div class="yui-b">
[% IF ( ! colId ) %]
<div class="dialog message">
<p>Invalid collection id</p>
<p><a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Return to rotating collections home</a></p>
</div>
[% ELSE %]
[% INCLUDE 'rotating-collections-toolbar.inc' %]
<h1>Collection <i>[% colTitle %]</i></h1>
[% IF ( previousActionAdd ) %]
@ -112,11 +117,11 @@
<div class="dialog message">There are no items in this collection.</div>
[% END %]
</div>
[% END %]
</div> <!-- /.yui-b -->
</div> <!-- /#yui-main -->
<div class="yui-b">
[% INCLUDE 'tools-menu.inc' %]
</div>
</div> <!-- /#bd -->
[% INCLUDE 'intranet-bottom.inc' %]
[% INCLUDE 'intranet-bottom.inc' %]