Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test, with this patchset applied:
1) From patron accounting page -> Add a manual invoice
2) Under the transaction tab click 'Cancel charge'
3) You should see a modal that gives you the option to type in a note.
4) Type something in and select submit.
5) Ensure the note shows up in the note column.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm.
3) In the transactions tab, for the invoice you just created, under the actions column select issue refund.
4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm.
5) Ensure the note correctly shows in the table.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
2) Under the actions column, select "Void"
3) Notice no option for a note. Press cancel
4) Apply patch, restart_all
5) Press void again. This time, you should see a modal that gives you the option to type in a note.
6) Type something in and select submit.
7) Ensure the note shows up in the note column.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
3) Under the actions column, select 'Issue Payout'
4) You can now enter a note. Type something in and press confirm.
5) Ensure the note shows up in the note column.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1) Apply manual invoice to a patron account
2) Go to the patron record -> accounting -> transaction tab
3) Look for the "Pay" button under the actions column. Click this
4) Notice no place to enter note
5) Click the "Write off" button. Notice there is no place to enter note
6) Apply patch, restart_all
7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs.
8) Write a not in the pay tab and confirm. Make sure this not shows up in the table.
9) Add another invoice and then test the note functionallity for the write-offs.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. APPLY PATCH and restart_all
2. Apply a manual invoice to a patron account.
3. Go to the patron record -> accounting -> transaction tab
4. Look for the 'Apply discount' button.
5. When the 'Apply discount' modal appears notcie the 'Note' field.
6. Add a note, make sure it gets applied to this accountline.
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
As requested, I've removed the superflous IF statement in the template..
I'll likely be adding it back in as part of the next patch series, but
it makes the history clear this way.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch hides the additional fields input on the library add/edit
page when there are no additional fields defined for libraries.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan, k-t-d:
1) Add a new additional field to 'branches':
<staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=branches
2) Click 'New field'. Add a name. Click Save.
3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category
(one repeatable, one not repeatable)
4) Edit a library:
<staff_url>/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL
5) Input various values in the different additional fields. Click
'Submit'
6) Visit the detail page of the library and verify the additional fields
data is displayed correctly:
<staff_url>/cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
0. Have some bookings that are ready to collect.
1. Load the bookings to collect report.
2. Table does not load.
3. APPLY PATCH
4. Try again, table loads.
5. Make sure you can filter by 'Pickup library'
Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Only show this attribute if defined
Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Only show this action button if the ILL request has a borrowernumber
Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.
Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch makes some simple markup and CSS changes to the course
details page in order to improve the layout of the section:
- Add colons after labels.
- Replace fieldset.rows with div.rows (there's no form).
- Make list of instructors line up with other details.
- Do not display fields which are empty.
ALSO: Replaced the "Reserves" heading with course name, matching
breadcrumbs and page title.
To test, apply the patch and go to Course reserves.
- If necessary, create a course.
- View the details of the course.
- Confirm that the list of details looks correct.
- Test with all the optional fields empty: Section, term, instructor,
staff note, public note. There should not be empty lines for these
fields in the course details.
- "Number of students" should show "0" if you left the field empty.
- Add multiple instructors to confirm that they are displayed in
alignment with other course details.
- The page heading should match the page breadcrumb.
Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Note:
I am using $rs in the script to prevent searching branches again
unneeded. And pass public_count to opac-library.tt to prevent
another call of Branches.all (for bread crumbs), like masthead
already does btw.
Test plan:
[1] Have two (or more) public libraries.
Verify that you see Libraries on the OPAC home page and that when
clicking Libraries, you first have the library list. Are the bread
crumbs as expected?
Click a library on that list. Do you get its details? Are the bread
crumbs as expected?
[2] Now have only one public library.
Verify that you see Contact on the home page.
And that when clicking Contact you go directly to the library details
without the intermediate library list. Are the bread crumbs still
as expected (with Contact instead of Libraries)?
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. Turn on EnableAdvancedCatalogingEditor
2. From the advanced editor, pull up the modal for macros.
3. Notice the size.
4. APPLY PATCH
5. Try step 2 again, this time the modal is wider.
6. Try on different screen sizes.
Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"
to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"
-apply patch
- verify there is the string
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. Make an item or item type 'Bookable'
2. Place a booking for that item
3. Go the 'Bookings' tab for that item.
4. Edit the booking
5. Submit the edit request and see at the top of the modal "Failure"
6. APPLY PATCH
7. Try editing bookings, now it should work.
Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds CSRF protection to patron list deletions.
Also changed: The "Delete selected lists" button is now in a floating
toolbar.
To test, apply the patch and go to Tools -> Patron lists.
- If necessary, create a few patron lists.
- Test the two methods for list deletion available on the page:
- Check one or more checkboxes and then click the "Delete selected
lists" at the top of the page.
- Click the "Actions" button for an individual list and choose "Delete
list."
- Open the checkout page for a patron.
- Under the "Patron lists" tab, add the patron to a list.
- Click the "Actions" button for an that list and choose "Delete
list."
- When you are taken to the patron lists page the list should have
been deleted.
- Perform the same test on the patron details page.
Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
acqui/booksellers.tt and admin/currency.tt use | $HtmlTags without first
filtering the string they wrap.
Test plan:
1. Without the patch, load the URL in comment 1, note the alert()
2. Apply patch, load the URL in comment 1, no alert()
Sponsored-by: Chetco Community Public Library
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan, works as advertised.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This change replaces single quotes with double quotes to prevent XSS
for particular operations on the circ returns page.
Test plan:
0. Apply the patch
1. Go to http://localhost:8081/cgi-bin/koha/circ/returns.pl?print_slip=1&reserve_id=1
2. Note that a pring slip is generated
(you may need to allow popups)
3. To test the XSS is patched, try the proof-of-concept from the
bug report
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4::Context->multivalue_preference is not used so far and split on |
However the values of "multiple" sysprefs are separated by... comma!
Let support both here.
This patch also removes silly JS code in the template.
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan:
Add article request with format via OPAC.
Run t/db_dependent/Koha/ArticleRequest.t
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tests in t/db_dependent/Koha/ArticleRequest.t pass. I can add an
article request with a type. If I allow PHOTOCOPY but change the
HTML in the OPAC form so SCAN is submitted I get a nice (but
somewhat generic) error.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch updates the serial claims interface to hopefully make it more
usable:
- Vendor selection and filter issues forms are in the sidebar
- The "Download selected" and "Send notification" forms are now in their
own columns at the bottom of the table of issues.
- NEW: The "Download selected" and "Send notification" forms are
disabled unless one or more issues are selected.
To test you'll need more than one vendor with subscriptions that have
late issues.
- Go to Serials -> Claims.
- You should see a "Choose vendor" form in the main part of the page.
- Choose a vendor.
- After selecting a vendor you should see the vendor selection form in
the sidebar along with a "Filter missing issues" form.
- Confirm that both forms work correctly.
- In the main body of the page you should see the table of missing
issues.
** Previously this table was sorted by default on the checkbox column.
Since that doesn't make sense I moved the default sort to the
"Since" column.
- Below the table of issues should should see the "Download selected"
form. If you have a claim notice defined, you'll also see a "Send
notification" form, each in their own column.
- These forms should initially be disabled.
- When you check a checkbox or click the "Select all" control at the
top of the checkbox column the forms should become active.
- Confirm that both forms work correctly.
Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Authorities still needed a few tweaks for text2 (obscure name for
plugins).
Upload plugin does not have buttonDot 'mark'. Cloning was still
an issue. Not the most elegant solution but it works. We should
not have this exception for just another icon or so.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The upload plugin button has no 'buttonDot' class (unlike other plugins
buttons) so its click event were not listened to.
This patch fix the CSS selector in order to listen on click events for
all plugins buttons
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This is to avoid using private jQuery method _data.
Here's what jQuery 1.8.0 release notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.
What this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually
This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
'mouseover' and 'mousemove' are not used and would trigger too much
events.
'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore
[1] https://learn.jquery.com/events/event-delegation/
Test plan:
- Go to every page that has a MARC editor and verify that plugins still
work. This includes addbiblio.pl, additem.pl, authorities.pl,
neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields
Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch amends the display constant for field 520 if the first
indicator is set to 8. According to MARC21 documentation
(https://www.loc.gov/marc/bibliographic/bd520.html), the field's
labels depend on the value of indicator 1.
First Indicator Second Indicator
Display constant controller
empty - Summary
0 - Subject
1 - Review
2 - Scope and content
3 - Abstract
4 - Content advice
8 - No display constant generated
Prior to this patch, a 520 field with ind1 = 8 is displayed as
'Summary'. After this patch, there is no label.
To test:
1. Create or edit a record, and add 7 x 520 tags:
- Add one 520 tag with no value in ind1, enter 'Summary' in 520$a
- Add one 520 tag with 0 in ind1, enter 'Subject' in 520$a
- Add one 520 tag with 1 in ind1, enter 'Review' in 520$a
- Add one 520 tag with 2 in ind1, enter 'Scope and content' in 520$a
- Add one 520 tag with 3 in ind1, enter 'Abstract' in 520$a
- Add one 520 tag with 4 in ind1, enter 'Content advice' in 520$a
- Add one 520 tag with 8 in ind1, enter 'No display constant
generated' in 520$a
2. View the record in the staff interface
--> The labels should be
- 'Summary' for the field that contains 'Summary' (OK)
- 'Subject' for the field that contains 'Subject' (OK)
- 'Review' for the field that contains 'Review' (OK)
- 'Scope and content' for the field that contains 'Scope and
content' (OK)
- 'Abstract' for the field that contains 'Abstract' (OK)
- 'Content advice' for the field that contains 'Content advice'
(OK)
- 'Summary' for the field that contains 'Subject' **(NOT OK)**
3. View the record in the OPAC
--> The labels should be
- 'Summary' for the field that contains 'Summary' (OK)
- 'Subject' for the field that contains 'Subject' (OK)
- 'Review' for the field that contains 'Review' (OK)
- 'Scope and content' for the field that contains 'Scope and
content' (OK)
- 'Abstract' for the field that contains 'Abstract' (OK)
- 'Content advice' for the field that contains 'Content advice'
(OK)
- 'Summary' for the field that contains 'Subject' **(NOT OK)**
4. Apply patch
5. Repeat step 2 (view the record in the staff interface; make sure to
refresh the page)
--> The labels should be
- 'Summary' for the field that contains 'Summary' (OK)
- 'Subject' for the field that contains 'Subject' (OK)
- 'Review' for the field that contains 'Review' (OK)
- 'Scope and content' for the field that contains 'Scope and
content' (OK)
- 'Abstract' for the field that contains 'Abstract' (OK)
- 'Content advice' for the field that contains 'Content advice'
(OK)
- Nothing for the field that contains 'Subject' (OK!!)
6. Repeat step 3 (view the record in the OPAC; make sure to refresh the
page)
--> The labels should be
- 'Summary' for the field that contains 'Summary' (OK)
- 'Subject' for the field that contains 'Subject' (OK)
- 'Review' for the field that contains 'Review' (OK)
- 'Scope and content' for the field that contains 'Scope and
content' (OK)
- 'Abstract' for the field that contains 'Abstract' (OK)
- 'Content advice' for the field that contains 'Content advice'
(OK)
- Nothing for the field that contains 'Subject' (OK!!)
https://bugs.koha-community.org/show_bug.cgi?id=38081
Signed-off-by: esther <esther@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
hold priorities a few times
--> Confirm that the priority is updated correctly
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To recreate:
1. Pick a framework and expose the 773$t ( title ), 773$g ( parts ), and 773$d ( Place, publisher, and date of publication )
2. Find a record and add some data to each of the fields in step 1.
3. Notice that the 773$d won't display.
4. APPLY PATCH and restart_all
5. Now the 773$d displays.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds btn and btn-primary classes
To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. APPLY PATCH, updatedatabase, restart_all
2. Search for the 'AlwaysShowHoldingsTableFilters' system preference. It should be set to 'Don't'.
3. Without changing the system preference, go to a record detail page.
4. The filters should not show by default.
5. Make sure that toggling the Hide filters/Show filters button still work as expected.
6. Set 'AlwaysShowHoldingsTableFilters' to 'Do'.
7. Now the filters should show by default when you load the table.
8. Make sure that toggling the Hide filters/Show filters button still work as expected.
Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
When ignoring a waiting hold, we don't need to take any further action, we
shoudlsimply close the modal
This patch adds JS to prevent form submission
To test:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
10 - Apply patch
11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
12 - check in the item again, confirm the modal says "Item is already waiting"
13 - click Ignore, nothign happens! Orange you glad I didn't say banana?
Signed-off-by: Amanda Campbell <acampbell@hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
