Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Marcel de Rooy	e5e5402f36	Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback We also need just one rollback at the end here. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Lari Taskula	f49f5a67d3	Bug 18991: Fix cleanup in t/db_dependent/Log.t There is an action_logs entry via logaction() without transaction to be rolled back in t/db_dependent/Log.t. This leaves an entry in action_logs after the test is over. To replicate: 1. prove t/db_dependent/Log.t 2. Observe a new entry in action_logs table To test: 1. Apply patch 2. prove t/db_dependent/Log.t 3. Observe there are no new entries in action_logs Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Tomás Cohen Arazi	3a7aaf1339	Bug 16829: Unit tests for logaction's 'interface parameter' This patch introduces tests for the new 'interface' parameter for the C4::Log::logaction and C4::Log::GetLogs functions. In logaction, it falls back to C4::Context->interface if ommited. To test: - Run $ prove t/db_dependent/Log.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	ca36ee3794	Bug 15939: Action logs - Do not default dates to today When accessing the modification logs from a link that does not explicitly set the to and from dates (e.g., from patron or bib details), no results are displayed unless the object had an action occur during the current day. This is a side-effect of commit `5dceb851` for bug 13813. Test plan: - View the modification logs of a record which has already been modified (/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=XXX) => Without this patch, you won't see any logs (unless you have modified the record today) => With this patch, the behavior is the same as prior bug 13813 (you can check in 3.20.x), you will see all logs Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Marc Véron	4307591f22	Bug 14977: Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Mark Tompsett	00faa967bd	Bug 13889: Add unit tests Previous commit was lacking test coverage of new function. TEST PLAN --------- 1) Apply all the patches 2) prove -v t/db_dependent/Log.t -- should be success. 3) koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Chris Cormack	7244d5060b	Fixing a broken test	13 years ago
MJ Ray	a746e11c14	Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. Signed-off-by: Liz Rea <lrea@nekls.org> Passes test, interface works as expected. Signed-off-by: Liz Rea <lrea@nekls.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago