Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	ca124b5c14	Bug 21817: Centralize the mock of userenv from tests This patch adds a new method mock_userenv from t::lib::Mocks in order to simplify the mock of the userenv. Test plan: prove all the test files modified by this patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Kyle Hall	e2e0c32701	Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	b1ba7fac2c	Bug 18292: Remove return 1 statements in tests The test files do not need to return 1 Patch generated with: perl -p -i -e "s/^1;\n//xsm" t/*/.t Test plan: git grep '^1;$' t/*/.t should not return any results NOTE: does not fix C4/SIP/t, nor xt tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Marcel de Rooy	d51d1899e8	Bug 17486: [QA Follow-up] Changes as to set_userenv Add shibboleth parameter to POD of set_userenv. Removed a 12th set_userenv parameter from Borrower_Discharge.t. Replaced set_userenv call in PatronLists.t looking like a fortunate typo. Test plan: Run the two corrected tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	427ba8b0c7	Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	f0983f0570	Bug 16452: Remove the warnings raised by PatronLists.t We need to define a userenv to get rid of the warnings Test plan: prove t/db_dependent/PatronLists.t should not return any warnings Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>	8 years ago
Kyle Hall	b41d5d0e8a	Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test Signed-off-by: Nora Blake <nblake@masslibsystem.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	3b70e7e62c	Bug 10565: Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' Signed-off-by: Nora Blake <nblake@masslibsystem.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago