Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	bee097b39b	Bug 14302: Remove GRS1 specific code Remove: - BIB_INDEX_MODE and AUTH_INDEX_MODE env var - bib_index_mode and auth_index_mode options from scripts - Warnings from about page, just kept one if zebra_bib_index_mode or zebra_auth_index_mode still exist in config and are set to grs1 Test plan: - Install Koha from src - Install Koha from pkg - Read the code, carefully! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	7 years ago
Tomás Cohen Arazi	357bb7e1e3	Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection This patch makes the t/db_dependent/Search.t tests use a real DB instead of mocking the DB handler (which is not actually used and generates unnecesary warnings when running the tests). It does so by grabbing the DB configuration data using C4::Context->config() and passing it (writing %ENV) to rewrite-config.PL, all is done in zebra_config.pl which is only used on the Search.t file. To test: - Run $ prove t/db_dependent/Search.t => FAIL: Warnings are raised about DB being mocked and DBIC not recognising 'Mock' as a valid DB driver. - Apply the patch - Run $ prove r/db_dependent/Search.t => SUCCESS: Same tests results, no warning about DBIC driver. - Sign off :-D Disclamer: As of writing this patch, the Search.t tests pass. The patch is not dealing with tests results, but how they use the DB. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass before & after, a 'little' less noisy No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Tomás Cohen Arazi	0a53d5e6b6	Bug 12651: DOM indexing is the default On the 23 July development meeting it was decided to formally deprecate GRS-1 indexing mode for Zebra. This patch makes code fallback to DOM on the remaining places. No behaviour change should be noticed, as DOM has been the default for a while. Regards Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Also checked running Makefile.PL Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Doug Kingston	88e7faf860	Bug 11078: Add locking to rebuild_zebra This patch adds locking to rebuild_zebra.pl to ensure that simultaneous changes are prevented (as one is likely to overwrite the other). Incremental updates in daemon mode will skipped if the lock is busy and they will be picked up on the next pass. Non-daemon mode invocations will also exit immediately if they cannot get the lock unless the new flag -wait-for-lock is specified, in which case they will wait until the get the lock and then proceed. Supporting changes made to Makefile.PL and templates for the new locking directory (paralleling the other zebra lock directories). We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl can find it. To address earlier QA concerns we: 1. added code to check if flock is available and ignore locking if it's missing (from M. de Rooy) 2. changed default for adhoc invocations to abort if they cannot obtain the lock. Added option -wait-for-lock if the user prefers to wait until the lock is free, and then continue processing. 3. added missing entry to t/db_dependent/zebra_config.pl 4. added a fallback locking directory of /tmp Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Doug merged the original patch with the QA changes. Just for the record, noting here that the original patch was tested extensively too by Martin Renvoize. I have added a followup for some exceptional cases. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Tomás Cohen Arazi	5666ed77a3	Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null \| grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes unit test, koha-qa.pl Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	5ca295738a	Bug 11137: regression tests for QP search field alias bug This patch adds regression tests to verify that Boolean searches using QueryParser function correctly. This patch also ensures that QP is correctly initalized when Search.t is run. To test: [1] Apply this patch and the following patch. [2] Verify that prove -v t/QueryParser.t works [3] Verify that prove -v t/db_dependent/Search.t works [4] (optional) instead of applying both patches at the same time, apply only the regression test patch and run the tests listed in steps 2 and 3. The following tests should fail: t/db_dependent/Search.t (Wstat: 512 Tests: 198 Failed: 2) Failed tests: 42, 71 Non-zero exit status: 2 t/QueryParser.t (Wstat: 256 Tests: 28 Failed: 1) Failed test: 12 Non-zero exit status: 1 Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	521e599dd8	Bug 7421: add regression tests for UNIMARC authorities DOM indexing This patch enhances t/db_dependent/Search.t to test indexing and searching of authority records. It supplies a sample authority file for MARC21 (consisting of the record for William Shakespeare from the Library of Congress) and a sample UNIMARC authority file supplied by Henri-Damien Laurent. It also adds tests for both MARC21 and UNIMARC authorities. When the main patch for bug 7421 is applied, t/db_dependent/Search.t should pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	1737ff4cc3	bug 8252: (follow-up) test both GRS1 and DOM indexing This patch expands t/db_dependent/Search.t to run the same tests using both the GRS-1 and DOM indexing modes. It also adds hooks in zebra_config.pl to make it easier to stage test cases for non-MARC21 Zebra indexing. Note that in DOM mode one of the tests is currently a TODO, as relevance ranking for wegihted queries differs between GRS-1 and DOM. To test: [1] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	574becb11a	bug 8649: create a temp directory for Zebra for C4::Search tests The Zebra test uses Unix-domain sockets, which won't work if Koha is being installed or tested from an NFS- or SSHFS-mounted clone. Therefore, create (and clenaup) a temporary directory on (hopefully) a normal filesytem to run the test. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	12 years ago
Jared Camins-Esakov	f9980f6b31	Bug 8649: Add unit test for C4::Search This patch adds a unit test for C4::Search in t/db_dependent. In order to test the functioning of the Zebra search, this patch actually includes an entire Zebra sandbox, and pre-indexed files, which are stored in t/db_dependent/data (the configuration files are generated on the fly). This test depends on Test::Warn, Test::MockModule, and DBD::Mock. To test: 1) Run the test. There should be no failures, and no warnings. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	12 years ago