Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	ddb1ecb9d8	Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework\|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Jonathan Druart	f3a8e5a411	Bug 17029: Fix XSS in catalogue/*detail.pl Hit /cgi-bin/koha/catalogue/detail.pl?biblionumber=1<script type="text/javascript">alert("XSS")</script> /cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=1<script type="text/javascript">alert("XSS")</script> /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=1<script type="text/javascript">alert("XSS")</script> /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1<script type="text/javascript">alert("XSS")</script> /cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=1<script type="text/javascript">alert("XSS")</script> => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	f3e4b5bbb6	Bug 16154: CGI->multi_param - Force scalar context This patch replaces the occurrences of $template->param( foo => $cgi->param('foo') ); with $template->param( foo => scalar $cgi->param('foo') ); perl -p -i -e 's/(\s=>\s)\$(cgi\|input\|query)\->param\(/$1scalar \$$2\->param\(/xms' */.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	c7ca45d046	Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl This patch removes only instance in this file. Also updates getframework POD on C4/Koha.pm, adds new GetFrameworksLoop() func on same file from suggested code, but with ordered result. To test: 1. Apply the patch 2. Enable viewLabeledMARC syspref 3. On staff, search for a record, goto detail view 4. Clic on Labeled MARC 5. Framework pulldown was replaced, check changing framework. A bug was fixed, because selecting any fw and then Default tries to load values from 'Default' fw code, which does not exists. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	63d7386ed0	Bug 11829: fix JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts do not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the "Normal" detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose "Delete record" from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose "Delete record" again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. I went through the test plan, everything works OK. It resolves Bug 11831 as well. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Printing from MARC and ISBD view works again - No more Javascript errors found - Deleting a record with attached order gives the correct warning, both for ordered and cancelled. Passes all tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Marcel de Rooy	e536fd087d	Bug 9823: QA follow-up for GetReservesFromBiblionumber calls The template params holds and holdcount are not used in the ISBD template. Removed the associated code from catalogue/ISBDdetail.pl. Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl. Same applies also for catalogue/imageviewer.pl. Same applies also for catalogue/moredetail.pl. In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. For consistency opac-detail should also incorporate future holds into its holds count; added the all_dates parameter for that reason. The Reserves module is no longer needed in moredetail. Removed it. Checked the other scripts also. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	8b685c1e80	Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaining a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	762c3304ea	Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	700f9980bb	Bug 5790 - Prevent deletion of records with holds Test Plan: 1) Apply patch 2) Create a record 3) Create an item for the record 3) Place a hold on the bib 4) Attempt to 'Delete all items', you should recieve an error message stating to delete all holds before deleting all items. Also, it is possible to get into a situation where a record has holds but no items. In this situation, it is not possible to view/delete the holds without adding an item back to the record. In this case, attempting to delete the bib causes a warning, but does not prevent deletion. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests - do note that it was a design decision to leave the delete links clickable even though they are grey. The reasoning is that librarians will want to be able to know why they cannot delete a given item or bib - I like this. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Tomás Cohen Arazi	36e3bed7b1	Bug 5791 - Robust handling of deleted/non-existent biblios and authority records Patch reworked for master using Template::Toolkit. To+ Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Owen Leonard	251e2c4d74	Fix for Bug 3659, Add place hold option from patron checkout tab Adds a button on patron-related pages, "Search to hold" Clicking search to hold sets a cookie with the patron's borrowernumber and sends the user to the search page. On subsequent search results pages the user will have the option to place holds specifically for the remembered patron. This works on the search results page (single and multiple hold) and on the detail page. The saved cookie will time out after 10 minutes or be erased when a new patron is loaded by circulation.pl New jQuery plugin added: jquery.cookie.min.js Revision fixes some markup and corrects an error that would lead to the hold being initiated for the remembered patron when this was not intended. Signed-off-by: Liz Rea <lrea@nekls.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Chris Cormack	e1b1c43425	Revert "Fix for Bug 3659, Add place hold option from patron checkout tab" This reverts commit `da2040634e`. Wrong patch was applied	14 years ago
Owen Leonard	da2040634e	Fix for Bug 3659, Add place hold option from patron checkout tab Adds a button on patron-related pages, "Search to hold" Clicking search to hold sets a cookie with the patron's borrowernumber and sends the user to the search page. On subsequent search results pages the user will have the option to place holds specifically for the remembered patron. This works on the search results page (single and multiple hold) and on the detail page. The saved cookie will time out after 10 minutes or be erased when a new patron is loaded by circulation.pl New jQuery plugin added: jquery.cookie.min.js Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Owen Leonard	fb5412c529	Fix for Bug 4849 - Cannot delete records from Labeled MARC view The template checks for a "count" variable (item count) to see whether it should allow deletion of the biblio record. For some reason labeledMARCdetail.pl hard-coded this as 1, which meant the template always thought was 1 item. This patch also adds an item count check on the display of "Delete all items," disabling it if there are no items. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Lars Wirzenius	034e2c1cbb	Fix FSF address in directory catalogue/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	15 years ago
Galen Charlton	38b3eacde0	bug 2641, 3263: minor fixes to labeled MARC view * fixed to XHTML validation errors * corrected copyright statement Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	15 years ago
Rick Welykochy	7504a1bb5a	bug 2641, 3263: Staff Search Results Interface Changes New detail view: labeled MARC New bib record view in the staff interface that displays the MARC record in a single page. Featured sponsored by MassCat. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	15 years ago

20 Commits (0a85759d3335c002233d7c7b07a8f8fcaeb22cae)